-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Verified account indicator #1821
Feat: Verified account indicator #1821
Conversation
Verified Artists are considered "Verified" on some pages and "Official Artist" on others. Would be curious as to whether they should be considered verified on all pages or not be considered verified. Would be interested in other opinions of this PR as well like "Only add a channel to cache on specific pages and not all pages" or whether verified channel caching should be implemented as a setting |
Can you clarify how YT makes this distinction? Ideally we should replicate their behavior here, but if this is not possible I would like to know why.
Is this particularly costly or disadvantageous? Is it a privacy concern? If no to either, then that should not be a setting. |
yt adds a music icon to Official Artists
I don't think so, I just saw this in a comment on the PR that this replaces |
invidious now shows verified information. I don't want to put any more effort into this feature at the time so I will be closing this PR. This PR can likely help if someone else were to try to implement this. (The cache stuff probably wouldn't be needed) |
Verified account indicator
Pull Request Type
Please select what type of pull request this is:
Related issue
#944
supercedes: #1095
Description
This PR will show verified indicators beside channel names when the data is available or it will look into a cache of verified channel ids to figure it out (ex: subscriptions page, most popular, using invidious api)
Screenshots (if appropriate)
![image](https://user-images.githubusercontent.com/78101139/137552700-edb55849-5349-4dac-8d9a-cf694af85d00.png)
Trending page:
Watch page:
![image](https://user-images.githubusercontent.com/78101139/137552847-9770efdc-4e98-47ba-ab70-649304860ae7.png)
Comments:
![image](https://user-images.githubusercontent.com/78101139/137552964-022c21d3-e41b-412f-b18e-7dbccb0744c2.png)
History:
![image](https://user-images.githubusercontent.com/78101139/137553071-f0220be5-bb26-41c1-80bd-1f48b4d53e53.png)
Channel:
![image](https://user-images.githubusercontent.com/78101139/137553127-c7147997-3afa-4caa-b0d0-1665a6b19352.png)
Playlist (List):
![image](https://user-images.githubusercontent.com/78101139/137553162-f516eb6b-b3e8-4a3a-8bdc-363d298b2bdf.png)
Playlist
![image](https://user-images.githubusercontent.com/78101139/137553279-26891d34-9e53-4ae3-84ae-8ed441eb8f76.png)
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
I navigated to different pages that could display veification check marks then navigated to pages that couldn't and added caching to support those
Desktop (please complete the following information):
Additional context
I don't know if something other than cache should be used instead for verified accounts because the cache clears on app close but I'm not sure what I'd do instead (a whole db just for verified channels?)