Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/channels page #2129

Merged
merged 8 commits into from
Jul 8, 2022
Merged

Feature/channels page #2129

merged 8 commits into from
Jul 8, 2022

Conversation

hockerschwan
Copy link
Contributor

@hockerschwan hockerschwan commented Mar 15, 2022 •
edited
Loading

Title

Pull Request Type

  • Feature Implementation

Related issue
Closes #1350
Closes #1506
Closes #2066

Description
Subscribed channels list (similar to ft-profile-channel-list)

Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable)
Manually adding/deleting channels

Desktop (please complete the following information):

  • OS: Windows 10
  • OS Version: 21H1
  • FreeTube version: 0.16.0

Additional context
Feedbacks appreciated ( spacing / size / wording etc.)
Reminder: rewrite thumbnailURL when #1783 is implemented.

@PrestonN PrestonN enabled auto-merge (squash) March 15, 2022 08:38
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

I think it better to move the channels tab icon to the top of the channels list on the sidebar because channels already has a dedicated section

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

I'll mark this with WIP because i'd like to see #1783 merged first

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Reminder: rewrite thumbnailURL when #1783 is implemented.

@hockerschwan #1783 has been merged

auto-merge was automatically disabled June 13, 2022 02:36

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 02:37
@hockerschwan
Copy link
Contributor Author

hockerschwan commented Jun 13, 2022 •
edited
Loading

added update thumbnail and unsubscribe prompt
profiles.txt thumbnails are replaced with http://example.com/image.jpg

ezgif-1-6db2b5f90d.mp4

I think it better to move the channels tab icon to the top of the channels list on the sidebar because channels already has a dedicated section

it looks ... out of place
z21

auto-merge was automatically disabled June 13, 2022 02:54

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 02:54
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 13, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 19, 2022
auto-merge was automatically disabled June 20, 2022 08:23

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) June 20, 2022 08:24
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 20, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing before approving. If list is empty hide the search bar. Just like it is implemented in the playlist and history page

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 20, 2022
auto-merge was automatically disabled June 20, 2022 16:13

Head branch was pushed to by a user without write access

@PrestonN PrestonN enabled auto-merge (squash) June 20, 2022 16:14
@hockerschwan
Copy link
Contributor Author

done

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 20, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 21, 2022 •
edited
Loading

i think that this pr closes #1350. IMO it wouldnt look nice in the sidebar but does look nice on this page.

@hockerschwan
Copy link
Contributor Author

yes. description updated

PikachuEXE
PikachuEXE reviewed Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review done
Give me some time to do local feature review...

@PrestonN PrestonN merged commit 94030b6 into FreeTubeApp:development Jul 8, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 8, 2022
@toby63
Copy link

toby63 commented Jul 8, 2022

Thx for implementing this, but could you add one more thing?
A way to optionally disable the channel list on the sidebar.

@absidue
Copy link
Member

absidue commented Jul 8, 2022

@toby63 That was already in FreeTube before this PR: Distraction Free Settings -> Hide Active Subscriptions

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@absidue maybe @toby63 means disabling the channels tab in the sidebar?

@toby63
Copy link

toby63 commented Jul 8, 2022

@absidue Thx, somehow I overlooked it, even though I was checking twice 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@GilgusMaximus GilgusMaximus GilgusMaximus approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue Awaiting requested review from absidue

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@hockerschwan @efb4f5ff-1298-471a-8973-3d47447115dc @toby63 @absidue @PikachuEXE @GilgusMaximus @PrestonN