-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update thumbnail url and channel name for subscriptions when change detected #1783
Fix: Update thumbnail url and channel name for subscriptions when change detected #1783
Conversation
the function to update thumbnails is pretty repetitive so I'm wondering if there's a file I can move it to so it only appears once (I'd update the function to take in thumbnail url & channel Id) |
I use this implementation for global functions in the Accessibility Improvements PR: Line 477 in 7391855
Note that the function name begins with a $ so as to explicitly denote that this function is global.
|
Just want to mention something that I've just found since creating #1677, it turns out it's not just channel icons in the subscription list that don't change, the channel name also doesn't update until you unsubscribe and resubscribe to the channel. |
@ChunkyProgrammer can u resolve the merge conflicts. i wanted to test but im unable to because of it :( |
I actually created the Utils Store for this exact reason. The idea is that miscellaneous functions that are used across the app but don't have a good spot to go typically goes into utils. I'm open to suggestions from you or @jasonhenriquez if this approach should be changed however, but that's how I've been handling it so far. |
Sounds good, I'll move the method to utils when I get the chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
- navigated to one of their videos (without navigating to channel)
- navigated to one of their playlists (without navigating to channel)
- navigated to their channel page.
@PikachuEXE No approval😔 |
@efb4f5ff-1298-471a-8973-3d47447115dc |
Yeah that's my bad for not noticing that 😬 |
196908a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update thumbnail url for subscriptions when change detected
Pull Request Type
Please select what type of pull request this is:
Related issue
Closes #1677
Description
When navigating to a channel, video or playlist page: it will check if the user is subscribed to the author & if they are subscribed then it will check if the thumbnail needs updating and will update the thumbnail accordingly
Testing (for code that is not small enough to be easily understandable)
I did the following for Invidious & local api:
I modified the thumbnail url to one of my subscriptions then:
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.