Migrate comments to YouTube.js #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
PR: dependencies
PikachuEXE
previously approved these changes
Jan 16, 2023
4 tasks
| * @param {import('youtubei.js/dist/src/parser/classes/comments/Comment').default} comment | ||
| */ | ||
| export function parseLocalComment(comment, hasOwnerReplied = false, replyToken = null) { | ||
| return { |
There was a problem hiding this comment.
I like this. We should probably return new objects for other api calls as well in the future (i think this would be very useful for our invidious functions)
There was a problem hiding this comment.
Yes, it will also allow us to return the data in the same format, that way we don't need separate handling for Invidious and local API data in ft-list-channel and similar components.
src/renderer/components/watch-video-comments/watch-video-comments.js
Outdated
Show resolved
Hide resolved
PikachuEXE
approved these changes
Jan 22, 2023
|
Tested with videos from the yt-comment-scraper tests: |
ChunkyProgrammer
approved these changes
Jan 23, 2023
|
@efb4f5ff-1298-471a-8973-3d47447115dc we need you! 馃槃 |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 24, 2023
github-actions
bot
removed
the
PR: waiting for review
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate comments to YouTube.js
Pull Request Type
Description
Migrated the comments to YouTube.js, this allows us to get rid of the
@freetube/yt-comment-scraperdependency.Nearly there 馃榿
Testing
Try the comments under various videos.
Desktop