Remove comment scraper #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested changes
Jan 24, 2023
usage/local-api.md
Outdated
| @@ -30,8 +30,7 @@ The Local API is one method of obtaining data from YouTube. For another method o | |||
| | ---------------------------------------------------------------------------------------- | ------- | ----------------------------------------------------------------------------------------------------------------- | -------------------------------- | | |||
| | [youtubei.js](https://github.com/LuanRT/YouTube.js) | MIT | Search Functionality + Suggestions, Playlists, Trending, Obtain Video Information, Generate DASH Files, Live Chat | No | | |||
| | [videojs-vtt-thumbnails-freetube](https://github.com/FreeTubeApp/videojs-vtt-thumbnails) | MIT | Handle Video Thumbnails / Storyboards | Yes | | |||
| | [yt-channel-info](https://github.com/FreeTubeApp/yt-channel-info) | ISC | Channel Info / Search | Yes | | |||
| | [yt-comment-scraper](https://github.com/FreeTubeApp/yt-comment-scraper) | GPL-3.0 | Comment Info / Sort | Yes | | |||
| | [yt-channel-info](https://github.com/FreeTubeApp/yt-channel-info) | ISC | Channel Info / Search | Yes | | Yes | | |||
There was a problem hiding this comment.
Big oof indeed. Is it possible for u to commit to this pr to fix it? I already turned off my machine and i am in snorlax mode
PikachuEXE
approved these changes
Jan 24, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
absidue and
ChunkyProgrammer
absidue
approved these changes
Jan 24, 2023
| @@ -30,7 +30,7 @@ The Local API is one method of obtaining data from YouTube. For another method o | |||
| | ---------------------------------------------------------------------------------------- | ------- | ----------------------------------------------------------------------------------------------------------------- | -------------------------------- | | |||
| | [youtubei.js](https://github.com/LuanRT/YouTube.js) | MIT | Search Functionality + Suggestions, Playlists, Trending, Obtain Video Information, Generate DASH Files, Live Chat | No | | |||
There was a problem hiding this comment.
Forgot to add Comments to this line 😆
There was a problem hiding this comment.
Do you mean adding fetching comments to yt.js?
There was a problem hiding this comment.
Yeah, I was mostly joking though because we'll probably make that line a lot smaller once we migrate from yt-channel-info
There was a problem hiding this comment.
Haha okay i initially thought that u were joking but then my head said but maybe it isnt a joke?
So yeah my brain playing tricks on me😅
Should i create a pr for adding the comments?
There was a problem hiding this comment.
I dont think it's necessary 🙂
ChunkyProgrammer
approved these changes
Jan 24, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
deleted the
efb4f5ff-1298-471a-8973-3d47447115dc-patch-1
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related FreeTubeApp/FreeTube#3072