Adjust side-nav-more-options to account for anchor style
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These nav-options were changed from `div`s to anchors, and so, they need to be styled like the `div`s that used to be there.
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
January 21, 2023 00:29
Pull request was converted to draft
ChunkyProgrammer
approved these changes
Jan 21, 2023
absidue
approved these changes
Jan 21, 2023
github-actions
bot
removed
the
PR: waiting for review
MarmadileManteater
added a commit
to MarmadileManteater/FreeTubeAndroid
that referenced
this pull request
Jan 22, 2023
commit bed2485 Merge: c7e7e7e 7ccb5dd Author: Emma <MarmadileManteater@proton.me> Merge remote-tracking branch 'upstream/development' into development commit c7e7e7e Author: Emma <MarmadileManteater@proton.me> Base Cordova build off of upstream web build (#84) commit 7ccb5dd Author: Emma <MarmadileManteater@proton.me> Adjust `side-nav-more-options` to account for anchor style (FreeTubeApp#3097) ... **Full Changelog**: 0.18.0-nightly-80...0.18.0-nightly-81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
side-nav-more-optionsto account for difference in style betweenrouter-linkanddivPull Request Type
Description
Somewhat recently, the
side-nav-more-optionsicons were changed to berouter-links instead ofdivs, but the style difference betweenrouter-linkanddivstill needs to be accounted for becauserouter-links carry with them all of the styles of anchors. Due to this, the text in the more options menu is the primary link color and the background color is not visible on hover (due to the display being inline). This PR aims to address this by adding some of the styles thatdivs have to the.navOptionclass in theside-nav-more-optionscomponent.Screenshots
Testing
Morenavbar item appears: (width < 678px).Morenavbar item.Moreare do not appear to be the primary link colorDesktop