Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Cordova build off of upstream web build #84

Merged
merged 381 commits into from Jan 22, 2023

Conversation

MarmadileManteater
Copy link
Owner

Base Cordova build off of upstream web build

Related Issues

#10

Description

Up until this point, the Cordova build process has involved taking the webpack output of a modified version of the webpack.renderer.config.js and forcing it through browserify. However, there is now a working web build upstream, so I felt like it would make more sense to base the Cordova build off of the upstream web build. Additionally, the original build process is difficult to maintain; it 😖breaks frequently, and since the move to YouTube.js for Local API upstream, I have not been able to pull in any upstream changes to the current development branch because browserify does not like something about how YouTube.js is included. The 🚚move to YouTube.js is ultimately a very positive change, but it was the straw that broke the 🐪back of the original cordova-build.js.

This PR is a complete refactor of the entire build process which removes many unnecessary steps and speeds up the entire process. It changes all of the package.json scripts related to Cordova:

  • yarn pack:browser is now -> yarn pack:cordova (for Android builds) & yarn pack:web (for web builds)
  • yarn build:cordova is still the same command, but you no longer need to run it before running: yarn run:cordova
    • It also takes one less argument. It no longer takes either of the inputs browser or cordova as the first argument. That argument is just skipped now. It isn't necessary anymore.
  • yarn run:cordova builds the app and launches it on a connected Android device. If you want to debug the web app in a browser, you can now use yarn dev:web.

This PR also includes a few changes which I never got around to implementing in the old build process before I stopped being able to update it. Such as:

  • Background play is much less inconsistent. Videos may stutter when entering the background, but they should no longer fully pause when entering the background.
    • There is also a new setting (under Cordova Settings) which allows users to toggle the background mode notification. The notification is enabled by default because Android can be greedy with system resources, but it is optional because I know some users will prefer not to have an additional notification on their screen any time the app is in the background.
  • There is now a splash screen which covers up the initial white screen before the app is loaded.

This PR also aims to clean-up the environments to make them more inline with upstream. Development is now where nightly builds live. Nightly builds can be found under GH actions just like it says in the README. Release is where releases live. Ideally, I will refrain from pushing releases to release as often as I have been with nightly, and this should reduce the amount of app updates pushed to users of the app who downloaded from IzzyOnDroid.

Screenshots

the new splashscreen which is displayed instead of a blank white screen the new setting which has been introduced

PikachuEXE and others added 30 commits December 19, 2022 20:57
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/de/
Currently translated at 99.5% (648 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fi/
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/fr/
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/en_GB/
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/
Currently translated at 23.3% (152 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hi/
Currently translated at 100.0% (651 of 651 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/hr/
Added overflow-wrap break word so that more of the clipped title is
displayed.

Co-authored-by: Simon Epstein <simon.epstein@67bricks.com>
* Fix strange embed playlist links missing /

* support embed/videoseries links

* remove duplicated replace line

Co-authored-by: petaded <code@zikl.co.uk>
* initial commit

* remove extra play button toggle

* add missing comment

Co-authored-by: Alin <ai6@tutanota.com>
Co-authored-by: ChunkyPtogrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/es/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/tr/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/gl/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/uk/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hans/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/zh_Hant/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/it/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/cs/
* Improve Watch page accessibility

Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>

* fix title issue, remove unused gotochannel function

Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt_PT/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/ja/
Currently translated at 100.0% (653 of 653 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pt/
Currently translated at 100.0% (657 of 657 strings)

Translation: FreeTube/Translations
Translate-URL: https://hosted.weblate.org/projects/free-tube/translations/pl/
@MarmadileManteater MarmadileManteater merged commit c7e7e7e into development Jan 22, 2023
MarmadileManteater added a commit that referenced this pull request Jan 22, 2023
commit bed2485
Merge: c7e7e7e 7ccb5dd
Author: Emma <MarmadileManteater@proton.me>

Merge remote-tracking branch 'upstream/development' into development

commit c7e7e7e
Author: Emma <MarmadileManteater@proton.me>

Base Cordova build off of upstream web build (#84)

commit 7ccb5dd
Author: Emma <MarmadileManteater@proton.me>

Adjust `side-nav-more-options` to account for anchor style (FreeTubeApp#3097)

...

**Full Changelog**: 0.18.0-nightly-80...0.18.0-nightly-81
@MarmadileManteater MarmadileManteater deleted the new-cordova-build branch March 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet