Fix live premieres being treated as non-live videos #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 25, 2023
|
in the videojs player? |
|
Yeah |
|
not sure if video.js lets us change that, other than to just remove it. |
PikachuEXE
reviewed
Mar 26, 2023
|
@PikachuEXE is that with or without this PR? That error occurs when it tries to use DASH for live premieres, as it was treating them like normal/non-live videos before this pull request. |
|
With and without this PR. That's why I am not sure if it's supposed to be fixed by this PR |
PikachuEXE
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Re-tested with https://youtu.be/VISznwVfJhM (actually live from same channel)
With latest development & this branch merged with latest development
Both works (can be played)
Could be just dev issue
ChunkyProgrammer
approved these changes
Apr 17, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 21, 2023
* development: Fix extracting chapters with handles from description (FreeTubeApp#3456) * Update video list display & watch page to not use stored watch progress when progress saving disabled (FreeTubeApp#3453) Update invidious-instances.json (FreeTubeApp#3440) Prevent loading for ever in web builds in live chat (FreeTubeApp#3449) Bump postcss from 8.4.21 to 8.4.22 (FreeTubeApp#3435) Bump html-webpack-plugin from 5.5.0 to 5.5.1 (FreeTubeApp#3432) Bump webpack from 5.78.0 to 5.79.0 (FreeTubeApp#3436) Bump sass from 1.61.0 to 1.62.0 (FreeTubeApp#3433) Fix "mention" in comments was rendered as link with channel URL (FreeTubeApp#3351) Fix live premieres being treated as non-live videos (FreeTubeApp#3358) Bump eslint-plugin-vue from 9.10.0 to 9.11.0 (FreeTubeApp#3434) Bump webpack-dev-server from 4.13.2 to 4.13.3 (FreeTubeApp#3437) Bump youtubei.js from 4.2.0 to 4.3.0 (FreeTubeApp#3438) Bump lefthook from 1.3.9 to 1.3.10 (FreeTubeApp#3439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix live premieres being treated as non-live videos
Pull Request Type
Related issue
closes #3310
Description
Currently we detect live videos on the watch page by checking isLive and isLiveContent, that is fine for normal live streams but for currently live premiere videos, the isLiveContent property is set to false. That caused live premiere videos to be treated as normal videos, causing errors.
I've now switched the check to just isLive. isLiveContent is still useful for detecting live stream replays, which we use to show a "streamed on x" text instead of "published on x" text.
Another way to look at it, is that anything with isLive and isLiveContent set to true, is being streamed from somewhere to YouTube and then to you, anything with isLive set to true but isLiveContent set to false, is already entirely on YouTube's servers so it's only getting streamed from YouTube to you.
Testing
Find a stream on https://www.youtube.com/@live (click on the live now header to see all of them that are currently live) that is live but is marked as premiere (scrolling down to load more and CTRL+F is your friend), you may have to use the 3 dots menu in the top right of the website to change location if there aren't any listed for your current location.
Desktop