Prevent loading forever in live chat in non-electron builds #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Apr 19, 2023
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Apr 19, 2023
absidue
approved these changes
Apr 19, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 21, 2023
* development: Fix extracting chapters with handles from description (FreeTubeApp#3456) * Update video list display & watch page to not use stored watch progress when progress saving disabled (FreeTubeApp#3453) Update invidious-instances.json (FreeTubeApp#3440) Prevent loading for ever in web builds in live chat (FreeTubeApp#3449) Bump postcss from 8.4.21 to 8.4.22 (FreeTubeApp#3435) Bump html-webpack-plugin from 5.5.0 to 5.5.1 (FreeTubeApp#3432) Bump webpack from 5.78.0 to 5.79.0 (FreeTubeApp#3436) Bump sass from 1.61.0 to 1.62.0 (FreeTubeApp#3433) Fix "mention" in comments was rendered as link with channel URL (FreeTubeApp#3351) Fix live premieres being treated as non-live videos (FreeTubeApp#3358) Bump eslint-plugin-vue from 9.10.0 to 9.11.0 (FreeTubeApp#3434) Bump webpack-dev-server from 4.13.2 to 4.13.3 (FreeTubeApp#3437) Bump youtubei.js from 4.2.0 to 4.3.0 (FreeTubeApp#3438) Bump lefthook from 1.3.9 to 1.3.10 (FreeTubeApp#3439)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent loading forever in live chat in non-electron builds
Pull Request Type
Related issue
MarmadileManteater#151
Description
In the created hook of the
watch-video-live-chatcomponent, theisLoadingflag is never set tofalsewhenprocess.env.IS_ELECTRONisfalse. The result is that the component appears to be loading forever, and never displays the appropriate message: "Live Chat is currently not supported in this build" in non-electron builds.Screenshots
Testing
yarn dev:webDesktop