Mobile/tablet channel page & share button visual improvements #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/mobile-and-tablet-channel-view-minor-styling-improvements
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
MarmadileManteater,
ChunkyProgrammer,
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Sep 21, 2023
ChunkyProgrammer
approved these changes
Sep 23, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 25, 2023
github-actions
bot
removed
the
PR: waiting for review
|
Just pulled down these changes, looks nice on mobile but takes up a significantly larger amount of space on desktop/wider screens, than before. Not sure I'm a fan, but I didn't get round to reviewing this pull request in time, so I don't really get to comment on that anymore. full screen screenshots after: |
|
Erg, that was probably an unintended byproduct of resolving line number six that I somehow missed. Sorry about that, I can change that. Sorry about these mini fixes! |
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 26, 2023
* development: (41 commits) Translated using Weblate (Finnish) Mobile/tablet channel page & share button visual improvements (FreeTubeApp#4061) Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator (FreeTubeApp#3942) Normalize ft-list-item grid height (FreeTubeApp#4043) Bump the stylelint group with 1 update (FreeTubeApp#4071) Bump the babel group with 1 update (FreeTubeApp#4069) Bump the eslint group with 1 update (FreeTubeApp#4070) Bump sass from 1.67.0 to 1.68.0 (FreeTubeApp#4072) Bump marked from 9.0.2 to 9.0.3 (FreeTubeApp#4073) Bump lefthook from 1.4.11 to 1.5.0 (FreeTubeApp#4074) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Greek) Translated using Weblate (German) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) Translated using Weblate (Icelandic) Translated using Weblate (Portuguese) Translated using Weblate (Polish) ! Fix in sub view, restoring last tab is bugged when visible tabs do not include tab to be restored (FreeTubeApp#4064) Translated using Weblate (Ukrainian) ... # Conflicts: # src/renderer/components/ft-prompt/ft-prompt.css
|
If you can fix number 6 without any visible differences to the normal layout that would be ideal :). |
|
TBH i really like how that after picture looks except for the searchbar placement. If that could be on the same height of the tabs it would look pretty neat IMO |
|
nvm we should fix this
|
1 task
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 8, 2023
* feature/playlist-2023-05: (176 commits) ! Fix playlist item fetching for local API (FreeTubeApp#4102) ! Fix watch page video published time parsing (FreeTubeApp#4105) Translated using Weblate (Serbian) Bump youtubei.js from 6.4.0 to 6.4.1 (FreeTubeApp#4090) Bump rimraf from 5.0.1 to 5.0.5 (FreeTubeApp#4091) Bump the stylelint group with 2 updates (FreeTubeApp#4088) Bump electron from 22.3.24 to 22.3.25 (FreeTubeApp#4089) Translated using Weblate (Bulgarian) Update FT history import to accept key lastViewedPlaylistId (FreeTubeApp#4038) ! Fix ft-video having different URLs in links Translated using Weblate (Dutch) Translated using Weblate (Lithuanian) Translated using Weblate (Japanese) Translated using Weblate (Croatian) Translated using Weblate (Estonian) Translated using Weblate (Croatian) ! Fix external player handling for video in local playlist Translated using Weblate (Finnish) Mobile/tablet channel page & share button visual improvements (FreeTubeApp#4061) Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator (FreeTubeApp#3942) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile/tablet channel page & share button visual improvements
Pull Request Type
Related issue
None
Description
Channel page changes:
overflow-x: scrolla. This is a better user experience and more closely matches with what we do on the tabs on other pages (e.g., the Subscribe tab).
Share button modal changes:
Screenshots
Before:
6:
After:
simplescreenrecorder-2023-09-20_19.22.02.mp4
Testing
Channel page:
Share button:
ft-share-buttondropdown.Desktop
Additional context
Note that there are some pre-existing visual bugs with the Watch route, particularly with the open share button dropdown clipping into the side when going from dialog view -> widen to dropdown view. We can clear these up in a later PR, but I have to stop adding things to this one first.
The mobile side nav is also broken in languages where the label text overflows to >= 2 lines, and the Settings tab disappears on viewport widths below ~350px. This is also pre-existing and better saved for a later PR.