Fix in subscription view, restoring last tab is bugged when visible tabs do not include tab to be restored #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not include tab to be restored
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
github-actions
bot
added
the
PR: waiting for review
absidue
approved these changes
Sep 23, 2023
ChunkyProgrammer
approved these changes
Sep 23, 2023
kommunarr
approved these changes
Sep 23, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 26, 2023
* development: (41 commits) Translated using Weblate (Finnish) Mobile/tablet channel page & share button visual improvements (FreeTubeApp#4061) Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator (FreeTubeApp#3942) Normalize ft-list-item grid height (FreeTubeApp#4043) Bump the stylelint group with 1 update (FreeTubeApp#4071) Bump the babel group with 1 update (FreeTubeApp#4069) Bump the eslint group with 1 update (FreeTubeApp#4070) Bump sass from 1.67.0 to 1.68.0 (FreeTubeApp#4072) Bump marked from 9.0.2 to 9.0.3 (FreeTubeApp#4073) Bump lefthook from 1.4.11 to 1.5.0 (FreeTubeApp#4074) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Greek) Translated using Weblate (German) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) Translated using Weblate (Icelandic) Translated using Weblate (Portuguese) Translated using Weblate (Polish) ! Fix in sub view, restoring last tab is bugged when visible tabs do not include tab to be restored (FreeTubeApp#4064) Translated using Weblate (Ukrainian) ... # Conflicts: # src/renderer/components/ft-prompt/ft-prompt.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Found this issue maybe when testing #3973 (but not related)
Description
When switching to subscription view, last tab view tab would be restored
But if visible tabs does not contain last tab, it should restore to 1st visible tab, but it displayed as no tab selected instead
Screenshots
Lazy
Testing
Desktop
Additional context