Fixed order of elements to allow for proper tabbing in comments section #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
I think it becomes unclickable when width is under 800px
|
|
It happens in multiple different width ranges from what I've seen, but I think this is a separate issue unrelated to these changes as I was able to recreate this behavior on develop. Should I open a new ticket? |
|
dev: tab order unexpected, but can be tabbed to, also clickable in all widths I would not accept the PR with the current state as I think the fix cannot be worse than the issue it tries to fix (making the sort element unclickable) |
|
Ah alright interesting, I was seeing it in both. I'll check out the problem and have a fix shortly. Thanks! |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
Hi @lamemakes just checking in, are u running into any issues? |
|
Hey! Still alive! Sorry for the delay, been running around like crazy but hoping to have a new commit to you guys by this week. Cheers! |
auto-merge was automatically disabled
November 4, 2023 04:13
Head branch was pushed to by a user without write access
|
Alright, she should be set. Again, sorry for the month long buffer between the initial PR and the fixes - life moved a little faster than I could keep up. Thanks for the patience! |
PikachuEXE
approved these changes
Nov 4, 2023
PikachuEXE
added
PR: waiting for review
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Nov 7, 2023
kommunarr
approved these changes
Nov 7, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 13, 2023
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
kommunarr
pushed a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2023
…on (FreeTubeApp#4099) * Rearranged elements and fixed css * Fixed unclickable comment sorting at 800<=width --------- Co-authored-by: Wes Appler <wes@lamemakes>
kommunarr
pushed a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2023
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
kommunarr
pushed a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2023
* development: (24 commits) Translated using Weblate (Arabic) Translated using Weblate (Ukrainian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Greek) Translated using Weblate (Russian) Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311) Translated using Weblate (Turkish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Portuguese) Translated using Weblate (Croatian) video id hash length to 4 (FreeTubeApp#4313) Translated using Weblate (Spanish) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) Add identifiers to channels hidden by ID (FreeTubeApp#4230) Translated using Weblate (Japanese) Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed order of elements to allow for proper tabbing in comments section
Pull Request Type
Related issue
Closes #4026.
Description
A (hopefully) quick one for y'all. Just rearranged the elements to be the expected tab order.
Cheers!
Screenshots
comment_tab_fix.webm
(sorry for short vid, my screen recorder was acting up tonight)
Testing
This was manually tested using tab.
Desktop
4398530Additional context
The only issues I saw (that existed before this fix) was the fact that when the window is resized, the "Sort Comments" drop down doesn't seem clickable. This might be my setup, but if you can recreate it let me know and I can write up a new issue for it.