Skip to content

Commit

Permalink
Fixed order of elements to allow for proper tabbing in comments secti…
Browse files Browse the repository at this point in the history
…on (FreeTubeApp#4099)

* Rearranged elements and fixed css

* Fixed unclickable comment sorting at 800<=width

---------

Co-authored-by: Wes Appler <wes@lamemakes>
  • Loading branch information
2 people authored and kommunarr committed Nov 18, 2023
1 parent 947cd3d commit c5d7c6c
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,21 @@

.commentsTitle {
padding-block: 1em;
display: inline-block;
}

.commentSort {
float: var(--float-right-ltr-rtl-value);
}

@media only screen and (max-width: 800px) {
.commentSort {
float: none;
inline-size: fit-content;
}
}


.comment {
padding: 15px;
position: relative;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@
<ft-card
class="card"
>
<h3
v-if="commentData.length > 0 && !isLoading && showComments"
class="commentsTitle"
>
{{ $t("Comments.Comments") }}
<span
class="hideComments"
role="button"
tabindex="0"
@click="showComments = false"
@keydown.space.prevent="showComments = false"
@keydown.enter.prevent="showComments = false"
>
{{ $t("Comments.Hide Comments") }}
</span>
</h3>
<h4
v-if="canPerformInitialCommentLoading"
class="getCommentsTitle"
Expand Down Expand Up @@ -33,22 +49,6 @@
:select-values="sortValues"
@change="handleSortChange"
/>
<h3
v-if="commentData.length > 0 && !isLoading && showComments"
class="commentsTitle"
>
{{ $t("Comments.Comments") }}
<span
class="hideComments"
role="button"
tabindex="0"
@click="showComments = false"
@keydown.space.prevent="showComments = false"
@keydown.enter.prevent="showComments = false"
>
{{ $t("Comments.Hide Comments") }}
</span>
</h3>
<div
v-if="commentData.length > 0 && showComments"
>
Expand Down

0 comments on commit c5d7c6c

Please sign in to comment.