Skip to content

Commit

Permalink
freetz_download: remove "don't check certificate" wget/git options
Browse files Browse the repository at this point in the history
This actually reverts 6f99493 and 188bd28.

The reasons for both are not documented. I have no clue why "not-checking" could be better.
Thanks to @PeterPawn for pointing it out.

Refs #214
  • Loading branch information
er13 committed Aug 9, 2019
1 parent 98f176f commit a229b0f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tools/freetz_download
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ do_download()

echo
[ "$DEBUG" == "1" ] && echo \
"wget -nd -t3 --timeout=20 --no-check-certificate --passive-ftp -N -P \"${1%/}/\" \"${fullURL}\""
wget -nd -t3 --timeout=20 --no-check-certificate --passive-ftp -N -P "${1%/}/" "${fullURL}"
"wget -nd -t3 --timeout=20 --passive-ftp -N -P \"${1%/}/\" \"${fullURL}\""
wget -nd -t3 --timeout=20 --passive-ftp -N -P "${1%/}/" "${fullURL}"
wget_result=$?
if [ "$wget_result" != "0" ]; then
echo "Download failed - \"${fullURL}\" -> error code $wget_result" >&2
Expand All @@ -67,8 +67,8 @@ do_check()
local mode wget_output wget_result
for mode in --spider --output-document=/dev/null; do
[ "$DEBUG" == "1" ] && \
echo "LC_ALL=C wget -t3 --timeout=20 --no-check-certificate --passive-ftp -S $mode \"$1\" 2>&1"
wget_output=$(LC_ALL=C wget -t3 --timeout=20 --no-check-certificate --passive-ftp -S $mode "$1" 2>&1)
echo "LC_ALL=C wget -t3 --timeout=20 --passive-ftp -S $mode \"$1\" 2>&1"
wget_output=$(LC_ALL=C wget -t3 --timeout=20 --passive-ftp -S $mode "$1" 2>&1)
wget_result=$?
if [ "$wget_result" != "0" ]; then
# workaround wget spider-mode bug (false negative): known to happen with all sites
Expand Down Expand Up @@ -120,7 +120,7 @@ do_checkout_svn()
}
do_checkout_git()
{
GIT_SSL_NO_VERIFY=true git clone "$1" "$2" \
git clone "$1" "$2" \
&& pushd "$2" >/dev/null \
&& git checkout "$3" \
&& LAST_COMMIT_TIMESTAMP=$(git log -1 --pretty=format:%cD) \
Expand Down

0 comments on commit a229b0f

Please sign in to comment.