This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Enhancement and Fixes for Bengali Transliteration. #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but this appears to break some testcases, can you have a look? |
cpfeiffer
reviewed
Sep 11, 2018
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/util/BengaliLanguageUtils.java
Outdated
Show resolved
Hide resolved
cpfeiffer
reviewed
Sep 11, 2018
.project
Outdated
| <natures> | ||
| <nature>org.eclipse.buildship.core.gradleprojectnature</nature> | ||
| </natures> | ||
| </projectDescription> |
There was a problem hiding this comment.
Is there any specific reason why you use Buildship instead of Android Studio and do we need to have these files in the repository?
There was a problem hiding this comment.
I think these should be added to .gitignore and removed from the PR. Especially if they're autogenerated.
|
Sorry that I was late. Was out on a tour. Fixed all the problems. |
cpfeiffer
reviewed
Sep 28, 2018
app/src/test/java/nodomain/freeyourgadget/gadgetbridge/test/LanguageUtilsTest.java
Outdated
Show resolved
Hide resolved
|
Hey, I think the build failure is not an issue from my branch. Right? |
|
It worked after rebasing from upstream! |
|
Thanks a lot, great job! 👍 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bengali pronunciation rules are sometimes complicated. I've tried to solve some problems with that and added some enhancement to make it more realistic.