New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement and Fixes for Bengali Transliteration. #1263

Merged
merged 13 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@uroybd
Copy link
Contributor

uroybd commented Sep 11, 2018

Bengali pronunciation rules are sometimes complicated. I've tried to solve some problems with that and added some enhancement to make it more realistic.

@cpfeiffer

This comment has been minimized.

Copy link
Contributor

cpfeiffer commented Sep 11, 2018

Thanks, but this appears to break some testcases, can you have a look?

nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationServiceTestCase > testTransliterationSupport FAILED
    java.lang.StringIndexOutOfBoundsException at DeviceCommunicationServiceTestCase.java:113
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateArabic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:41
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateHebrew FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:31
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateLithuanian FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:77
nodomain.freeyourgadget.gadgetbridge.test.LanguageUtilsTest > testStringTransliterateCyrillic FAILED
    java.lang.StringIndexOutOfBoundsException at LanguageUtilsTest.java:22
nodomain.freeyourgadget.gadgetbridge.test.CalendarEventTest > testSync FAILED
    junit.framework.AssertionFailedError at CalendarEventTest.java:54
.project Outdated
<natures>
<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
</natures>
</projectDescription>

This comment has been minimized.

@cpfeiffer

cpfeiffer Sep 11, 2018

Contributor

Is there any specific reason why you use Buildship instead of Android Studio and do we need to have these files in the repository?

This comment has been minimized.

@TaaviE

TaaviE Sep 11, 2018

Contributor

I think these should be added to .gitignore and removed from the PR. Especially if they're autogenerated.

@uroybd

This comment has been minimized.

Copy link
Contributor Author

uroybd commented Sep 20, 2018

Sorry that I was late. Was out on a tour. Fixed all the problems.

@uroybd

This comment has been minimized.

Copy link
Contributor Author

uroybd commented Sep 29, 2018

Hey, I think the build failure is not an issue from my branch. Right?

@uroybd uroybd force-pushed the uroybd:master branch from 6b1bfaf to 1813ba4 Oct 1, 2018

@uroybd

This comment has been minimized.

Copy link
Contributor Author

uroybd commented Oct 1, 2018

It worked after rebasing from upstream!

@cpfeiffer cpfeiffer merged commit e66d0a2 into Freeyourgadget:master Oct 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpfeiffer

This comment has been minimized.

Copy link
Contributor

cpfeiffer commented Oct 1, 2018

Thanks a lot, great job! 👍 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment