Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magma Spawn tweaks [$61 awarded] #1054

Closed
DreadKnight opened this issue Aug 25, 2016 · 21 comments
Closed

Magma Spawn tweaks [$61 awarded] #1054

DreadKnight opened this issue Aug 25, 2016 · 21 comments
Assignees
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming
Milestone

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Aug 25, 2016

Boiling Point - this ability is passive.
Leaves 2 puddles of hot lava under, lasting 1 round or until stepped on.
10 burn damage for each hexagon.
Upgrade: Will last until stepped on.

This one basically remains the same. It won't hurt Magma Spawns or flying/hovering units that won't stop over them.

I've added an upgrade that enables the traps to last indefinitely until triggered or destroyed.

Pulverizing Hit - costs 15 energy pts.
Smacks a foe with its very heavy hand, gaining bonus damage with every hit.
6 crush damage + 4 burn each strike.
Upgrade: 2 stacks if hitting same foe.

I've tweaked the damage a little for this one. The burn bonus damage stack will be added after the strike.

The upgrade will cause a debuff "mark" on the last hit target only, so that each time striking it with Pulverizing Hit again, you get double burn damage buff. So ideally, you wouldn't change target unless it's dead.

Cracked Earth - costs 20 energy pts.
Smashes both fists into the ground, wreaking fierce havoc in area ahead.
10 burn damage over all 8 hexagons.
Upgrade: It can spawn hot lava traps.

This one remains the same basically.

The upgrade will cause hot lava traps from Boiling Point ability to appear in any of the 8 targeted hexagons that didn't hit anything. So even if an unit dies in the target area because of this ability, it won't leave traps where the unit was. The traps generated will behave the same way as the ones from Boiling Point, so if Boiling Point ability is upgraded, the traps will remain there until activated or destroyed.

Molten Hurl - costs 30 energy pts.
Bowls itself into first inline foe, while destroying all the traps along the way.
10 crush + 5 burn damage & movement.
Upgrade: Can mow down multiple foes.

This will destroy any traps, including own, even from under the location it starts. Magma Spawn could be moved first in order to avoid eliminating the traps from the passive. The regular version of the ability shouldn't display dashed hexagons after the possible target(s).

The upgrade will cause it to keep moving & hitting more inline units every time the last target died. The upgrade should add dashed hexagons inline, indicating this possibility.

--- The **[$61 bounty](https://www.bountysource.com/issues/37275959-magma-spawn-tweaks?utm_campaign=plugin&utm_content=tracker%2F260151&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F260151&utm_medium=issues&utm_source=github).
@DreadKnight DreadKnight added coding This issue requires some programming abilities The issue is related to an unit ability or more labels Aug 25, 2016
@DreadKnight DreadKnight added this to the 0.3 - Bouncer milestone Aug 25, 2016
DreadKnight added a commit that referenced this issue Aug 25, 2016
@DreadKnight DreadKnight changed the title Magma Spawn tweaks Magma Spawn tweaks [$10] Aug 26, 2016
@cxong cxong self-assigned this Sep 2, 2016
cxong added a commit that referenced this issue Sep 2, 2016
cxong added a commit that referenced this issue Sep 2, 2016
@cxong
Copy link
Contributor

cxong commented Sep 3, 2016

Should cracked earth be useable even if there are no targets? So like just leave a bunch of traps if it's upgraded

cxong added a commit that referenced this issue Sep 3, 2016
@DreadKnight
Copy link
Member Author

Definitely. It's like that atm.
On Sep 3, 2016 11:56 AM, "Cong" notifications@github.com wrote:

Should cracked earth be useable even if there are no targets? So like just
leave a bunch of traps if it's upgraded


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1054 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj235rFWpqE40ZJch74GuyFBzLHbZRMks5qmTY-gaJpZM4JtIr4
.

@cxong
Copy link
Contributor

cxong commented Sep 3, 2016

What should Molten Hurl do if there's no next creature? Just go to the edge of the map?

cxong added a commit that referenced this issue Sep 3, 2016
@DreadKnight
Copy link
Member Author

Hmm, good question. Will need to think about it a bit, a lot of variables into play: Magma Spawn has low movement stat, units tend to leave drops (if enabled and dead), Molten Hurl requires enemy target and upgrades tend to impose new outcomes, which I try hard to not have them backfire as much as possible.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 4, 2016

Alright, I think this is the best logic for the ability: since Molten Hurl can't be used without a foe target inline, it shouldn't proceed to the edge of the map either, it only triggers again on kill if there is another inline foe.

cxong added a commit that referenced this issue Sep 5, 2016
@DreadKnight
Copy link
Member Author

Molten Hurl doesn't seem to continue when killing target. I've set the ability upgrades to enabled btw.

[{"action":"ability","target":{"type":"hex","x":6,"y":4},"id":3,"args":{"1":{"creature":"L3","cost":6}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":8,"y":4},"id":3,"args":{"1":{"creature":"A1","cost":2}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":7,"y":4}]},"id":1,"args":{"1":{"direction":4}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":11,"y":4},"id":3,"args":{"1":{"creature":"E2","cost":4}}},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":8,"y":4},"id":3,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"ability","target":{"type":"array","array":[{"x":8,"y":4},{"x":8,"y":4}]},"id":3,"args":{"1":{"direction":1}}},{"action":"skip"}]

cxong added a commit that referenced this issue Sep 6, 2016
DreadKnight added a commit that referenced this issue Sep 7, 2016
@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

Did a bit of testing and as far as I can tell, there seems to be a bug with Pulverizing Hit's upgrade, which doubles all the previous accumulated stacks. The ability should only gain 2 stacks instead of 1 each time it hits the unit it previously did with Pulverizing Hit. You can see here a huge damage leap from 19 to 37 or so:

[{"action":"ability","target":{"type":"hex","x":6,"y":4},"id":3,"args":{"1":{"creature":"L3","cost":6}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":11,"y":3},"id":3,"args":{"1":{"creature":"P7","cost":10}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":10,"y":4},"id":3,"args":{"1":{"creature":"P6","cost":9}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":11,"y":5},"id":3,"args":{"1":{"creature":"S5","cost":8}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"move","target":{"x":8,"y":3}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":10,"y":3}},{"action":"skip"},{"action":"move","target":{"x":10,"y":5}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":5},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":6},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}}]

Started this one with Upgrades: Enabled btw.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

Over here it even doubled damage from 26 to 52, there's something fishy going on... (upgrades enabled).

[{"action":"ability","target":{"type":"hex","x":6,"y":4},"id":3,"args":{"1":{"creature":"L3","cost":6}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":11,"y":3},"id":3,"args":{"1":{"creature":"P7","cost":10}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":10,"y":4},"id":3,"args":{"1":{"creature":"P6","cost":9}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":11,"y":5},"id":3,"args":{"1":{"creature":"S5","cost":8}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"move","target":{"x":8,"y":3}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":10,"y":3}},{"action":"skip"},{"action":"move","target":{"x":10,"y":5}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":5},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":6},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"ability","target":{"type":"array","array":[{"x":9,"y":2},{"x":9,"y":3},{"x":10,"y":3},{"x":8,"y":4},{"x":9,"y":4},{"x":9,"y":5},{"x":10,"y":5},{"x":9,"y":6}]},"id":2,"args":{"1":{"direction":-1}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":6},"id":1,"args":{"1":{}}},{"action":"ability","target":{"type":"array","array":[{"x":9,"y":2},{"x":9,"y":3},{"x":10,"y":3},{"x":8,"y":4},{"x":9,"y":4},{"x":9,"y":5},{"x":10,"y":5},{"x":9,"y":6}]},"id":2,"args":{"1":{"direction":-1}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":6},"id":1,"args":{"1":{}}}]

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

So in a scenario with upgrades enabled, Magma Spawn would hit Uncle Fungus with Pulverizing Hit for 10 damage (gaining a stack), second time it would do 13 damage (original 10 + the first stack, while gaining two other stacks this time), third time it would do about 19 damage or so (original 10 + 9 from the 3 stacks, while also gaining 2 more stacks for the next hit). But how it's coded right now, it's like 10 damage, while the second hit is 20, third hit being 27 (stats interfering a bit...).

Though the initial 3 burn damage, since it's done on the first hit, could technically considered first stack.

@cxong
Copy link
Contributor

cxong commented Sep 7, 2016

So does "stack" mean number of times it's used? Why would the second hit do 13 damage instead of 16, because it's 7 + 3*3 because first time is one stack, second it's two more stacks because it is hitting the same target?

@cxong
Copy link
Contributor

cxong commented Sep 7, 2016

also, do the stacks reset once it attacks a different target? Is this separate from the number of times the ability is used in total? Are the stacks per-creature, as in if it attacks one target, switches to a second, then goes back to the first, does it keep the bonus damage from the stacks gained from attacking the first target?

@DreadKnight
Copy link
Member Author

The stacks never reset. The stacks could be granted even if the ability is blocked, like vs Dark Priests.

When upgraded, you get a bonus stack when you attack the same unit with the ability in a row: so first hit will give you 1 stack, second hit will give you 2 stacks, third hit will give you 2 stacks as well and so on.

If you change unit, only from the second hit you will grant that extra stack. If you go back to the previously hit unit, you need to hit it twice in a row again. Existing stacks are kept when switching between units, but in order to get a better boost, Magma Spawn should focus on the same unit to get that extra stack on hit.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

So does "stack" mean number of times it's used? Why would the second hit do 13 damage instead of 16, because it's 7 + 3*3 because first time is one stack, second it's two more stacks because it is hitting the same target?

Stack is not always the number of times used. The first 3 burn damage the ability has could be considered a stack. Also, the upgrade creates a mini-game where you have to focus the same unit to "farm" stacks faster.

The first hit does 10 damage and grants you a stack, which is 3 bonus burn damage, so the second hit would be using that 3 damage as well, doing 13. If the ability is upgraded and the hit done on same target, it would grant you not one but two more stacks, meaning the next hit (third) would do 19 damage (10 initial and 3 stacks of 3 damage), but if it's done on new target, you would only get one new stack instead of two.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

@cxong I'm guessing you also amplified the current hit damage by adding those stacks instantly.
This ability is kinda inspired from Dota 2, Ursa - Fury Swipes ability, which does it kinda like that.

@cxong
Copy link
Contributor

cxong commented Sep 7, 2016

are stacks shared among all magma spawns? like in a 2v2 game

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 7, 2016

They're individual, like practicing out :D Stacks are like a self unit buff basically. This is why the first one could be considered a stack, as in next version we'll have the buff interface fixed (revamped actually), so the first thing for Magma Spawn over there could be a Pulverizing Hit buff being displayed.

cxong added a commit that referenced this issue Sep 11, 2016
@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 14, 2016

Upgraded Cracked Earth should also leave a trap under Magma Spawn's first hexagon towards the direction being used and Molten Hurl should destroy any traps under as well. This way Magma Spawn can be way more efficient against Impaler's Poisonous Vine ability and others similar to it.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 14, 2016

Pulverizing Hit is still not working properly, as it reset damage (stacks) when switching to another target.

[{"action":"ability","target":{"type":"hex","x":4,"y":4},"id":3,"args":{"1":{"creature":"L3","cost":6}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":12,"y":4},"id":3,"args":{"1":{"creature":"P7","cost":10}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":7,"y":4},"id":2,"args":{}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":15,"y":5},"id":3,"args":{"1":{"creature":"G3","cost":5}}},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":7,"y":5},"id":2,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":6,"y":6}},{"action":"move","target":{"x":6,"y":5}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":4},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":5},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":5},"id":1,"args":{"1":{}}}]

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 14, 2016

Seems you're applying the Pulverizing Hit bonus damage stacks per unit, instead of summing them up.
That makes Magma Spawn way more balanced overall, so we can leave Pulverizing Hit as it is atm 👍
This way skilled players can also aim to keep certain units away from it to avoid having them pulverized.

@DreadKnight
Copy link
Member Author

DreadKnight commented Sep 14, 2016

Received an error, game got stuck :/

Uncaught TypeError: crea.takeDamage is not a function ancientbeast.js:11344

I managed to get the log this time:

[{"action":"ability","target":{"type":"hex","x":4,"y":4},"id":3,"args":{"1":{"creature":"S5","cost":8}}},{"action":"skip"},{"action":"ability","target":{"type":"hex","x":12,"y":4},"id":3,"args":{"1":{"creature":"L3","cost":6}}},{"action":"skip"},{"action":"move","target":{"x":7,"y":4}},{"action":"move","target":{"x":8,"y":4}},{"action":"ability","target":{"type":"creature","crea":4},"id":2,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":8,"y":2},{"x":9,"y":3},{"x":8,"y":3},{"x":10,"y":4},{"x":9,"y":4},{"x":8,"y":4},{"x":9,"y":5},{"x":8,"y":5},{"x":8,"y":6}]},"id":2,"args":{"1":{"direction":-1}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":8,"y":2},{"x":9,"y":3},{"x":8,"y":3},{"x":10,"y":4},{"x":9,"y":4},{"x":8,"y":4},{"x":9,"y":5},{"x":8,"y":5},{"x":8,"y":6}]},"id":2,"args":{"1":{"direction":-1}}},{"action":"move","target":{"x":13,"y":5}},{"action":"skip"},{"action":"move","target":{"x":8,"y":5}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":10,"y":5},{"x":9,"y":5},{"x":8,"y":5},{"x":8,"y":5},{"x":7,"y":5},{"x":6,"y":5}]},"id":3,"args":{"1":{"direction":4}}},{"action":"ability","target":{"type":"creature","crea":3},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":3},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"creature","crea":3},"id":1,"args":{"1":{}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"ability","target":{"type":"array","array":[{"x":7,"y":3},{"x":7,"y":4},{"x":6,"y":4},{"x":9,"y":5},{"x":8,"y":5},{"x":7,"y":5},{"x":7,"y":6},{"x":6,"y":6},{"x":7,"y":7}]},"id":2,"args":{"1":{"direction":4}}},{"action":"move","target":{"x":12,"y":4}},{"action":"ability","target":{"type":"array","array":[{"x":9,"y":4},{"x":8,"y":4},{"x":7,"y":4},{"x":6,"y":4},{"x":5,"y":4},{"x":4,"y":4},{"x":3,"y":4},{"x":2,"y":4},{"x":1,"y":4},{"x":0,"y":4},{"x":0,"y":4}]},"id":3,"args":{"1":{"direction":4}}},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"skip"},{"action":"move","target":{"x":8,"y":6}},{"action":"move","target":{"x":11,"y":5}}]

@DreadKnight DreadKnight changed the title Magma Spawn tweaks [$10] Magma Spawn tweaks [$61] Sep 14, 2016
@DreadKnight
Copy link
Member Author

Seems to work fine now, well done!

@DreadKnight DreadKnight changed the title Magma Spawn tweaks [$61] Magma Spawn tweaks [$61 awarded] Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming
Projects
None yet
Development

No branches or pull requests

2 participants