Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problematic random creature button #1553

Closed
DreadKnight opened this issue Oct 11, 2019 · 9 comments
Closed

problematic random creature button #1553

DreadKnight opened this issue Oct 11, 2019 · 9 comments

Comments

@DreadKnight
Copy link
Member

@DreadKnight DreadKnight commented Oct 11, 2019

Reproducing these steps results in the Godlet Printer ability being selected with no creature actually selected to be materialized within Dark Priest's radius instead of just selecting a creature in dash mode.

  • select Godlet Printer ability
  • select a creature to materialize
  • right click anywhere to open dash
  • press the big button from under cards
@c3ho

This comment has been minimized.

Copy link
Contributor

@c3ho c3ho commented Oct 11, 2019

I'll try working on this issue as well. There's a few things I'll need clarifications on

  • currently when right clicking on an space will send the user to the Godlet Printer defaulted to the Dark Priest, should it default to the last viewed monster instead if that is available?

  • currently when right clicking on the Dark Priest will send the user to the Godlet Printer defaulted to the Dark priest, what should happen here?

@DreadKnight

This comment has been minimized.

Copy link
Member Author

@DreadKnight DreadKnight commented Oct 12, 2019

@c3ho Awesome, patches always welcomed <3 Here are your answers:

  • sure, that would make more sense and actually improve flow a bit overall
  • basically when you right click a specific unit, its cards should be focused

Units get modified by buffs/debuffs, hence the right clicking specific units to see them in dash.
We used to have a nice way of seeing the modifiers, but it got broken with time, though a new and hopefully better way/UI is planned #844

@c3ho

This comment has been minimized.

Copy link
Contributor

@c3ho c3ho commented Oct 12, 2019

@DreadKnight okay in that scenario, we may have a problem, because only one copy of the creature can only be on the field per player right? Unless you view another player's creature.

@DreadKnight

This comment has been minimized.

Copy link
Member Author

@DreadKnight DreadKnight commented Oct 12, 2019

@c3ho Given time, some creatures might have clones. Guessing at that point creatures will be defined with an unique generated id or creation or so.

@c3ho

This comment has been minimized.

Copy link
Contributor

@c3ho c3ho commented Oct 16, 2019

I managed to fix half of the issue, when right clicking on an empty space, it will check for the last viewed creature. If there has not been a creature(clicked and viewed from the Godlet Printer) it will always default to Dark Priest in the Godlet Printer. That seems to fix the issue:

  • select Godlet Printer ability
  • select a creature to materialize
  • right click anywhere to open dash
  • press the big button from under cards

That leaves the other half of the problem, what should happen when there was a last viewed unit but right clicked on the Dark Priest and then the player clicked on the Materialize button?

@DreadKnight

This comment has been minimized.

Copy link
Member Author

@DreadKnight DreadKnight commented Oct 16, 2019

@c3ho The materialize button tends to select a random materializable unit when clicked in that scenario.

@c3ho

This comment has been minimized.

Copy link
Contributor

@c3ho c3ho commented Oct 23, 2019

With all that said, actually do you think it would be better to disable all materialize functions when viewing a creature(including dark priest) on the field with right click and only allow the materialize function when right clicking on an empty hex?

It seems kind of weird to see a "Materialize for X plasma" when a picture of the dark priest is displayed from the showCreature function haha

@DreadKnight

This comment has been minimized.

Copy link
Member Author

@DreadKnight DreadKnight commented Oct 23, 2019

@c3ho That's true, good point! I guess we could replace that large materialize button in the future with unit status icons (buffs and debuffs) when viewing creatures that are already materialized or not dead.

@c3ho

This comment has been minimized.

Copy link
Contributor

@c3ho c3ho commented Oct 23, 2019

Submitted PR #1555 to fix this issue

@DreadKnight DreadKnight unpinned this issue Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.