You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DreadKnight opened this issue
Apr 25, 2024
· 6 comments
Assignees
Labels
abilitiesThe issue is related to an unit ability or morebountySome amount of our token, XatteR, is offeredcodingThis issue requires some programmingeasyGood place to start if you're a new developerinputDeals with hotkeys, interaction & accessibility
As follow-up to issue #2533 's fix, Uncle Fungus's Frogger Jump ability could show up transparent cardboard preview to the hovered target location
The text was updated successfully, but these errors were encountered:
DreadKnight
added
coding
This issue requires some programming
abilities
The issue is related to an unit ability or more
easy
Good place to start if you're a new developer
input
Deals with hotkeys, interaction & accessibility
bounty
Some amount of our token, XatteR, is offered
labels
Apr 25, 2024
@DreadKnight this one seems good to go, but just a quick question. At the bottom of the hexgrid code I found a function called fadeOutTempCreature that has a comment above it mentioning factoring it out but it seems to do exactly what we need when using the previewCreature function so I used it for this ability. Does this seem ok?
@gg447062 Took a peek at it. Well, ideally it would be to do things as indicated in the comment there it seems 🐻
You could use that and I could open new issue regarding the TODO refactoring 🤔 hopefully it won't create chaos.
Ok from what I can tell, that function is only used twice so I don't think it should cause too much chaos to refactor it. I think the thing that confused me about the comment was that it mentions the existing temp creature created by /src/abilities/Dark-Priest.js but unless I'm totally off the temp creature is this.materialize_overlay, which is also not an instance of Creature.creatureSprite.
Ok from what I can tell, that function is only used twice so I don't think it should cause too much chaos to refactor it. I think the thing that confused me about the comment was that it mentions the existing temp creature created by /src/abilities/Dark-Priest.js but unless I'm totally off the temp creature is this.materialize_overlay, which is also not an instance of Creature.creatureSprite.
@gg447062 Comment could be wrong, I'm not sure. Feel free to poke at it and make a PR 🐻
abilitiesThe issue is related to an unit ability or morebountySome amount of our token, XatteR, is offeredcodingThis issue requires some programmingeasyGood place to start if you're a new developerinputDeals with hotkeys, interaction & accessibility
As follow-up to issue #2533 's fix, Uncle Fungus's Frogger Jump ability could show up transparent cardboard preview to the hovered target location
The text was updated successfully, but these errors were encountered: