Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken Fiery Touch [$5 awarded] #968

Closed
DreadKnight opened this issue May 23, 2016 · 8 comments
Closed

broken Fiery Touch [$5 awarded] #968

DreadKnight opened this issue May 23, 2016 · 8 comments
Assignees
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming priority This should get fixed as soon as possible!
Milestone

Comments

@DreadKnight
Copy link
Member

DreadKnight commented May 23, 2016

Can't attack any more units using Abolished's Fiery Touch.

--- The **[$5 bounty](https://www.bountysource.com/issues/34492341-broken-fiery-touch?utm_campaign=plugin&utm_content=tracker%2F260151&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F260151&utm_medium=issues&utm_source=github).
@DreadKnight DreadKnight added coding This issue requires some programming abilities The issue is related to an unit ability or more priority This should get fixed as soon as possible! labels May 23, 2016
@DreadKnight DreadKnight added this to the 0.3 - Bouncer milestone May 23, 2016
@DreadKnight
Copy link
Member Author

@cxong I think one of the changes you made broke this specific ability, might be something simple.

@cxong
Copy link
Contributor

cxong commented May 31, 2016

If that's true, then I think that's 👍 to setting up automated unit tests. Have you thought about what framework we should use? I think it comes down to Jasmine or Mocha. The sooner we start, the less we'll see bugs like this.

@DreadKnight
Copy link
Member Author

Hehe, indeed. Like I mentioned before, I think Mocha does things better. Will do a little more research today though.

@DreadKnight DreadKnight changed the title broken Fiery Touch broken Fiery Touch [$5] Jul 21, 2016
cxong added a commit that referenced this issue Jul 25, 2016
@cxong cxong self-assigned this Jul 25, 2016
@DreadKnight
Copy link
Member Author

Tested it and it works. Make sure you assign yourself to BS so I can award the bounty, @cxong . Can't go under $5 afaik for issues though xD

@DreadKnight
Copy link
Member Author

Can't award the bounty cause you didn't submitted a patch after you "started working on it" on BS... @cxong sigh

@cxong
Copy link
Contributor

cxong commented Aug 2, 2016

So what do I need to do? Submit a dummy patch?

@DreadKnight
Copy link
Member Author

@cxong Yeah, I think so. Patch that other thing and it might work if you tag this one too; We'll have to see xD BS has a 5$ minimum per issue, so I might need to group the small "low hanging fruits" issues or leave them for coders who want crediting / experience only.

DreadKnight added a commit that referenced this issue Aug 4, 2016
This is a dummy patch just to get the bounty for #968
@DreadKnight DreadKnight reopened this Aug 4, 2016
@DreadKnight
Copy link
Member Author

@cxong Guess you can try clicking the "Claim Bounty" button https://www.bountysource.com/issues/34492341-broken-fiery-touch

@DreadKnight DreadKnight changed the title broken Fiery Touch [$5] broken Fiery Touch [$5 awarded] Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abilities The issue is related to an unit ability or more coding This issue requires some programming priority This should get fixed as soon as possible!
Projects
None yet
Development

No branches or pull requests

4 participants