Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] improve autoselect ip_address of interfaces #138

Merged
merged 1 commit into from
May 8, 2018

Conversation

genofire
Copy link
Member

@genofire genofire commented May 8, 2018

Description

#137

Motivation and Context

Checklist:

  • My code follows the code style of this project.
  • I have added also tests for my new code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@genofire
Copy link
Member Author

genofire commented May 8, 2018

@Grotax would you like to test this PR?

@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #138 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   73.68%   73.77%   +0.09%     
==========================================
  Files          47       47              
  Lines        1573     1571       -2     
==========================================
  Hits         1159     1159              
+ Misses        386      384       -2     
  Partials       28       28
Impacted Files Coverage Δ
respond/collector.go 24.72% <0%> (+0.26%) ⬆️

@genofire
Copy link
Member Author

genofire commented May 8, 2018

@mweinelt Would you also test this PR ?

@Grotax
Copy link

Grotax commented May 8, 2018

Applied patch, removed ip_address from config.
Restarted - it works. 👍

@mweinelt
Copy link
Contributor

mweinelt commented May 8, 2018

@genofire It's difficult to do this within our automation tooling, so if Grotax review is sufficient I rather wouldn't.

@genofire genofire merged commit 7e97b69 into master May 8, 2018
@genofire genofire deleted the improve-interface branch May 8, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants