Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script checks for php-dom vs php-xml #1094

Closed
plietar opened this issue Feb 24, 2016 · 2 comments
Closed

Install script checks for php-dom vs php-xml #1094

plietar opened this issue Feb 24, 2016 · 2 comments
Assignees
Labels
Work in progress 🚧 Wait before merging
Milestone

Comments

@plietar
Copy link

plietar commented Feb 24, 2016

Hi,
I've noticed an issue in the extension checks done by the install script :
If the dom extension is missing, the install script asks the user to install the xml extension.
If the dom extension is present but the xml is not, the install script happily proceeds, but retrieving feeds will fail as SimplePie requires it.

Both extensions are required by FreshRSS I believe, and should have their own check.

@Alkarex Alkarex added this to the 1.3.1-beta milestone Feb 25, 2016
@Alkarex
Copy link
Member

Alkarex commented Feb 25, 2016

Thanks for the bug report. I thought the XML extension was always available, but indeed, it is possible to explicitly opt-out http://php.net/manual/xml.installation.php

If you have time, it would be great if you could make a pull request (otherwise, I will try to add a check before the next beta). See:

Alkarex added a commit that referenced this issue Feb 28, 2016
Add note about Referer #565
Add note about DOM / XML extensions
#1094
@Alkarex Alkarex self-assigned this Feb 28, 2016
@Alkarex Alkarex added the Work in progress 🚧 Wait before merging label Feb 28, 2016
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Feb 28, 2016
@Alkarex
Copy link
Member

Alkarex commented Feb 28, 2016

Check added in #1097

@Alkarex Alkarex closed this as completed Feb 28, 2016
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work in progress 🚧 Wait before merging
Projects
None yet
Development

No branches or pull requests

2 participants