Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite affects whole article display #2618

Closed
Frenzie opened this issue Nov 1, 2019 · 4 comments
Closed

Favorite affects whole article display #2618

Frenzie opened this issue Nov 1, 2019 · 4 comments
Assignees
Labels
UI 🎨 User Interfaces
Milestone

Comments

@Frenzie
Copy link
Member

Frenzie commented Nov 1, 2019

v1.15

Same as #2604. There might also be a minor issue with hover in some circumstances.

@Frenzie Frenzie self-assigned this Nov 1, 2019
@Alkarex Alkarex added this to the 1.16.0 milestone Nov 1, 2019
@Alkarex Alkarex added the UI 🎨 User Interfaces label Nov 1, 2019
@Alkarex Alkarex modified the milestones: 1.16.0, 1.15.1 Nov 1, 2019
@Alkarex
Copy link
Member

Alkarex commented Nov 2, 2019

@Frenzie Let's issue a fast release 1.15.1 for fixing a couple of regressions. It would be nice if that could include this issue

@Frenzie
Copy link
Member Author

Frenzie commented Nov 2, 2019

Sure thing, this shouldn't take long. Not this afternoon though. :)

@marienfressinaud
Copy link
Member

Do you think you'll have time tonight? :) Otherwise, I'll work on it tomorrow morning so we can release the 1.15.1 in the afternoon or evening

@Frenzie
Copy link
Member Author

Frenzie commented Nov 4, 2019

@marienfressinaud My spare time is fairly occupied until Wednesday (Bill Bailey tomorrow ;-) ), so feel free to go ahead if you want it done tomorrow.

marienfressinaud added a commit to flusio/FreshRSS that referenced this issue Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

I didn't apply the fix to the Ansum and Mapco designs because they
already had this behaviour before the commit.

Related PRs:

- FreshRSS#2477
- FreshRSS#2611
- FreshRSS#2612

Closes FreshRSS#2618
marienfressinaud added a commit to flusio/FreshRSS that referenced this issue Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

I didn't apply the fix to the Ansum and Mapco designs because they
already had this behaviour before the commit.

Related PRs:

- FreshRSS#2477
- FreshRSS#2611
- FreshRSS#2612

Closes FreshRSS#2618
marienfressinaud added a commit to flusio/FreshRSS that referenced this issue Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

I didn't apply the fix to the Ansum and Mapco designs because they
already had this behaviour before the commit.

Related PRs:

- FreshRSS#2477
- FreshRSS#2611
- FreshRSS#2612

Closes FreshRSS#2618
marienfressinaud added a commit to flusio/FreshRSS that referenced this issue Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

Related PRs:

- FreshRSS#2477
- FreshRSS#2611
- FreshRSS#2612

Closes FreshRSS#2618
marienfressinaud added a commit that referenced this issue Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

Related PRs:

- #2477
- #2611
- #2612

Closes #2618
@Alkarex Alkarex closed this as completed Nov 5, 2019
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
`.current`).

Bug introduced in e9ce27d

Related PRs:

- FreshRSS#2477
- FreshRSS#2611
- FreshRSS#2612

Closes FreshRSS#2618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

No branches or pull requests

3 participants