[fix] Origine unread CSS style #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
Oct 28, 2019
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
Oct 28, 2019
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
Oct 28, 2019
Merged
Alkarex
pushed a commit
that referenced
this pull request
Oct 28, 2019
marienfressinaud
added a commit
to flusio/FreshRSS
that referenced
this pull request
Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d I didn't apply the fix to the Ansum and Mapco designs because they already had this behaviour before the commit. Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
marienfressinaud
added a commit
to flusio/FreshRSS
that referenced
this pull request
Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d I didn't apply the fix to the Ansum and Mapco designs because they already had this behaviour before the commit. Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
marienfressinaud
added a commit
to flusio/FreshRSS
that referenced
this pull request
Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d I didn't apply the fix to the Ansum and Mapco designs because they already had this behaviour before the commit. Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
marienfressinaud
added a commit
to flusio/FreshRSS
that referenced
this pull request
Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
marienfressinaud
added a commit
that referenced
this pull request
Nov 5, 2019
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d Related PRs: - #2477 - #2611 - #2612 Closes #2618
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* [fix] Flat unread CSS style Same as FreshRSS#2611. * [fix] Origine-Compact unread CSS style Same as FreshRSS#2611. * [fix] Swage unread CSS style Same as FreshRSS#2611.
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2604. Regression in #2477.
NB I likely introduced the issue in other themes as well. It looked sane when I tested it at the time but I failed to notice the specific issue as in #2604. I'll test and fix other themes tomorrow (if applicable).