Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming to WebSub #2184

Merged
merged 1 commit into from Dec 16, 2018
Merged

Update naming to WebSub #2184

merged 1 commit into from Dec 16, 2018

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Dec 16, 2018

Instead of PubSubHubbub / PuSH

@Alkarex
Update naming to WebSub
ae0c8a8 
Instead of PubSubHubbub / PuSH
@Alkarex Alkarex added this to the 1.13.0 milestone Dec 16, 2018
@Alkarex Alkarex added the API 🤝 API for other clients label Dec 16, 2018
@Alkarex Alkarex merged commit 512d047 into FreshRSS:dev Dec 16, 2018
@Alkarex Alkarex deleted the WebSub-documentation branch December 16, 2018 16:02
@pattems
Copy link
Contributor

pattems commented Dec 16, 2018

Is it your intent to rename the variables in code, or just renaming the public-facing stuff? random example of what I'm talking about:

FreshRSS/app/Controllers/feedController.php

Line 270 in e04804d

$pubsubhubbubEnabledGeneral = FreshRSS_Context::$system_conf->pubsubhubbub_enabled;

@Alkarex
Copy link
Member Author

Alkarex commented Dec 16, 2018 •
edited

@pattems Just the public-facing part for now. I would like to avoid opening new potential breaking changes before the 1.13.0 release. We can do that in 1.14 if needed

Alkarex added a commit that referenced this pull request Dec 16, 2018
@Alkarex
Changelog 2184
76718e6 
#2184
@Alkarex Alkarex mentioned this pull request Dec 16, 2018
Merged
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
@Alkarex
Update naming to WebSub (FreshRSS#2184)
7ccf7b5 
Instead of PubSubHubbub / PuSH
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
@Alkarex
Changelog 2184
67836ba 
FreshRSS#2184
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@Alkarex @mdemoss
Update naming to WebSub (FreshRSS#2184)
52747bf 
Instead of PubSubHubbub / PuSH
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@Alkarex @mdemoss
Changelog 2184
deca721 
FreshRSS#2184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API 🤝 API for other clients Documentation 📚
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alkarex @pattems