Minz: Attach a notification to a request #3208
Conversation
Notifications should be attached to a request, not to a global session. Fix FreshRSS#3096 (comment) Prepare FreshRSS#3096
|
I like what you've done here. I was wondering if it could be a good idea to have more than one setter for that matter. Let me explain! This way, there is no need to rely on a constant value everywhere in the codebase, which is prone to errors. I've used the words success and failure in the method names but it could message levels like in monolog. |
|
@marienfressinaud Just for the record, if this Minz codebase is used in any other context, the former way of setting notifications is still possible |
I hope it isn't haha 😄 |
Implement mutex for notifications FreshRSS#3208 (comment)
* Minz allow parallel sessions #fix #3093 * Array optimisation * Array optimisation missing * Reduce direct access to $_SESSION except in install process * Fix session start headers warning * Use cookie only the first time the session is started: `PHP Warning: session_start(): Cannot start session when headers already sent in /var/www/FreshRSS/lib/Minz/Session.php on line 39` * New concept of volatile session for API calls Optimisation: do not use cookies or local storage at all for API calls without a Web session Fix warning: ``` PHP Warning: session_destroy(): Trying to destroy uninitialized session in Unknown on line 0 ``` * Only call Minz_Session::init once in our index It was called twice (once indirectly via FreshRSS->init()) * Whitespace * Mutex for notifications Implement mutex for notifications #3208 (comment) * Typo * Install script is not ready for using Minz_Session
Caused by FreshRSS#3208 Before, the 'rid' parameter was saved as part of the user query.
Caused by #3208 Before, the 'rid' parameter was saved as part of the user query.
Notifications should be attached to a request, not to a global session.
Implement #3096 (comment)
Prepare #3096