Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement subscription management page #3893

Merged
merged 13 commits into from
Oct 19, 2021
Merged

enhancement subscription management page #3893

merged 13 commits into from
Oct 19, 2021

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Oct 15, 2021

Closes #3257

Before:
grafik

grafik

grafik

After:
grafik

grafik

grafik

Changes proposed in this pull request:
see screenshots
(the button "show only feeds with errors" appears only, when there are errors)

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH mentioned this pull request Oct 15, 2021
Closed
Frenzie
Frenzie approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, something about the alignment of that button at the top looks potentially a bit weird?

app/views/helpers/category/update.phtml Outdated Show resolved Hide resolved
math-GH and others added 4 commits October 16, 2021 12:06
@math-GH
Copy link
Contributor Author

math-GH commented Oct 16, 2021

lgtm, something about the alignment of that button at the top looks potentially a bit weird?

fixed

grafik

@Frenzie
Copy link
Member

Frenzie commented Oct 16, 2021

That .box style is only used on that specific page?

@math-GH
Copy link
Contributor Author

math-GH commented Oct 16, 2021

That .box style is only used on that specific page?

also in user queries pages (new layout still on the edge branch)
grafik

@Frenzie
Copy link
Member

Frenzie commented Oct 16, 2021 •
edited
Loading

also in user queries pages (new layout still on the edge branch)

In any case, as long as you've made sure it looks good everywhere it's used. ^_^ 👍

@Alkarex Alkarex added this to the 1.19.0 milestone Oct 16, 2021
@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 16, 2021
Alkarex
Alkarex requested changes Oct 19, 2021
View reviewed changes
app/i18n/en/sub.php Outdated Show resolved Hide resolved
@Alkarex Alkarex merged commit 3623a54 into FreshRSS:edge Oct 19, 2021
@math-GH math-GH deleted the 3257-enhancement-subscription-management-page-feeds-with-errors branch October 19, 2021 14:35
@Frenzie Frenzie mentioned this pull request Nov 3, 2021
Merged
4 tasks
@Alkarex Alkarex mentioned this pull request Dec 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

@Alkarex Alkarex Alkarex approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted UI 🎨 User Interfaces
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

enhancements: show "show only feeds with errors" at top and only if errors exist?
3 participants
@math-GH @Frenzie @Alkarex