Improved: Mouse title on empty feeds #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
reviewed
Sep 15, 2022
app/views/index/global.phtml
Outdated
| @@ -46,7 +46,8 @@ | |||
| $url_base['params']['get'] = 'f_' . $feed->id(); | |||
| ?> | |||
| <li id="f_<?= $feed->id() ?>" class="item feed<?= $error, $empty, $feed->mute() ? ' mute' : '' ?>" | |||
| data-unread="<?= $feed->nbNotRead() ?>" data-priority="<?= $feed->priority() ?>"> | |||
| data-unread="<?= $feed->nbNotRead() ?>" data-priority="<?= $feed->priority() ?>" | |||
| title="<?= strlen($error) > 0 ? _t('sub.feed.error') : ''?> <?= strlen($empty) > 0 ? _t('sub.feed.empty') : '' ?>"> | |||
There was a problem hiding this comment.
I think $error === '' might be slightly faster than strlen() and it makes a bit more sense to me
Alkarex
reviewed
Sep 18, 2022
Alkarex
reviewed
Sep 18, 2022
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
empty feeds are marked with orange font color.
after:
The mouse gives the information
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist: