Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Improve translation: zh-cn #4856

Merged
merged 1 commit into from Nov 20, 2022
Merged

[i18n] Improve translation: zh-cn #4856

merged 1 commit into from Nov 20, 2022

Conversation

myuki
Copy link
Contributor

@myuki myuki commented Nov 15, 2022

Changes proposed in this pull request:

  • Review all zh-cn translation and improve.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@myuki
Copy link
Contributor Author

myuki commented Nov 15, 2022

I review all zh-cn translation, and found some weird string in en. Same thing has different expression in admin.php and install.php like:

'nok' => 'Cannot find JSON (php-json package).',

And

'nok' => 'Cannot find the recommended library to parse JSON.',

Also requiremented libraries has different name. Some prefix php- and some suffix package like (php-pcre),(PCRE), (ctype),(php-curl package).

Are those intentional or not?

@Alkarex Alkarex added this to the 1.21.0 milestone Nov 15, 2022
@Alkarex Alkarex added the I18n 🌍 Translations label Nov 15, 2022
@Alkarex
Copy link
Member

Alkarex commented Nov 15, 2022

Thanks!

Are those intentional or not?

No, this is not intentional, so feel free to make more uniform in your translations.

@myuki
Copy link
Contributor Author

myuki commented Nov 15, 2022

Thanks!

Are those intentional or not?

No, this is not intentional, so feel free to make more uniform in your translations.

Thanks for your reply. I may do some uniform for en, en-us and zh-cn in new PR.

@Alkarex Alkarex merged commit 77c214c into FreshRSS:edge Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants