Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved: delete .nav-list .empty/.error #4899

Merged
merged 1 commit into from
Nov 27, 2022
Merged

improved: delete .nav-list .empty/.error #4899

merged 1 commit into from
Nov 27, 2022

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Nov 26, 2022 •
edited
Loading

If I do not overlook something, then .nav-list does not have .empty or .error as sub-classes anymore
grafik

So we can delete the CSS

Changes proposed in this pull request:

  • CSS

How to test the feature manually:

  1. check the code

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the System care Everything related to the system care label Nov 26, 2022
@math-GH math-GH added this to the 1.21.0 milestone Nov 26, 2022
Frenzie
Frenzie approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I'm not 100% sure you're not overlooking something. ;-p

@Alkarex Alkarex merged commit b718062 into FreshRSS:edge Nov 27, 2022
@math-GH
Copy link
Contributor Author

math-GH commented Nov 27, 2022

Seems fine, but I'm not 100% sure you're not overlooking something. ;-p

:D Sometimes it is better for me to check the dictionary first :D (I changed it now from "oversee" to "overlook")

@math-GH math-GH deleted the delete-navlist-itemempty branch November 28, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
System care Everything related to the system care
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@math-GH @Frenzie @Alkarex