PHPStan level 9 for ./p/ and lib_rss.php #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And app/FreshRSS.php Contributes to FreshRSS#4112
aledeg
reviewed
Jan 28, 2023
| @@ -17,10 +17,14 @@ class FreshRSS_Entry extends Minz_Model { | |||
| */ | |||
| private $guid; | |||
|
|
|||
| /** @var string */ | |||
There was a problem hiding this comment.
Can't you add the type directly in the property definition?
There was a problem hiding this comment.
That would require PHP 7.4+: https://php.net/language.types.declarations
With PHP 7.2 (which we support at the moment #4848 ): PHP Parse error: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in ./app/Models/Entry.php on line 18
There was a problem hiding this comment.
Let's come back to it in a few months #3321 (comment)
There was a problem hiding this comment.
Interesting reading; there are several details I did not know (e.g. about uninitialized properties) https://wiki.php.net/rfc/typed_properties_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
app/FreshRSS.php.Contributes to #4112 (addresses 146 level-6 errors)
Refactored
greader.phpas a class with private functions.