Consistent entry ID type (32-bit compatibility) #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface was not used, and it was preventing more precise types for the different `searchById()` methods, as they each have different input and output types.
Entry IDs (which are 64-bit integers) must be processed as string to be compatible with 32-bit platforms
Alkarex
added
API 🤝
Alkarex
changed the title
Alkarex
commented
Mar 19, 2023
| return $this->entriesToIdList($entries); | ||
| } | ||
|
|
||
| /** | ||
| * @return integer|false | ||
| */ | ||
| private function setItemAsRead(int $id) { | ||
| private function setItemAsRead(string $id) { |
There was a problem hiding this comment.
Example, which was breaking 32-bit compatibility
Alkarex
commented
Mar 19, 2023
| @@ -303,7 +307,7 @@ public function updateEntry(array $valuesTmp) { | |||
| * @todo simplify the query by removing the str_repeat. I am pretty sure | |||
| * there is an other way to do that. | |||
| * | |||
| * @param integer|array $ids | |||
| * @param string|array<string> $ids | |||
There was a problem hiding this comment.
Example of wrong type hint, breaking 32-bit compatibility
ColonelMoutarde
approved these changes
Mar 20, 2023
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 18, 2024
Native type forgotten from FreshRSS#5269 FreshRSS#5213
Alkarex
added a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry IDs (which are 64-bit integers) must be processed as string to be compatible with 32-bit platforms.
In some previous type hints PR, this was a bit messed with.
(NB: Category / Feed / Tag IDs are 32-bit integers, so they can be passed as
intwithout problem)#5212 must be merged first.
P.S. The last commits add PHPStan level 6 for affected files