Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan Level6 for View.php #5269

Merged
merged 14 commits into from Apr 7, 2023
Merged

Phpstan Level6 for View.php #5269

merged 14 commits into from Apr 7, 2023

Conversation

ColonelMoutarde
Copy link
Contributor

Changes proposed in this pull request:

  • Phpstan Level6 for View.php

Pull request checklist:

  • clear commit messages
  • code manually tested

Alkarex
Alkarex reviewed Apr 6, 2023
View reviewed changes
tests/phpstan-next.txt Outdated Show resolved Hide resolved
@Alkarex Alkarex added the System care Everything related to the system care label Apr 6, 2023
@Alkarex Alkarex added this to the 1.22.0 milestone Apr 6, 2023
Alkarex
Alkarex reviewed Apr 6, 2023
View reviewed changes
lib/Minz/View.php Outdated Show resolved Hide resolved
Alkarex
Alkarex reviewed Apr 6, 2023
View reviewed changes
lib/Minz/View.php Outdated Show resolved Hide resolved
Alkarex
Alkarex reviewed Apr 6, 2023
View reviewed changes
lib/Minz/View.php Outdated Show resolved Hide resolved
ColonelMoutarde and others added 3 commits April 6, 2023 13:59
@ColonelMoutarde @Alkarex
Apply suggestions from code review
a37df52 
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Remarque's from Alkarex
2d493ed
@Alkarex
A few improvements
c0ec012
@Alkarex
Copy link
Member

Alkarex commented Apr 6, 2023

I have made a few more improvements / fixes c0ec012
Please double-check.
If you feel like it, it would be nice to address ./app/Models/View.php, which is the natural next step after ./lib/Minz/View.php, either in this PR or a new one.

@ColonelMoutarde
Copy link
Contributor Author

I have made a few more improvements / fixes c0ec012 Please double-check. If you feel like it, it would be nice to address ./app/Models/View.php, which is the natural next step after ./lib/Minz/View.php, either in this PR or a new one.

I add ./app/Models/View.php quickly

@ColonelMoutarde
Copy link
Contributor Author

I have made a few more improvements / fixes c0ec012 Please double-check. If you feel like it, it would be nice to address ./app/Models/View.php, which is the natural next step after ./lib/Minz/View.php, either in this PR or a new one.

done

@ColonelMoutarde ColonelMoutarde marked this pull request as draft April 6, 2023 16:12
@ColonelMoutarde ColonelMoutarde marked this pull request as ready for review April 6, 2023 17:16
@Alkarex
Copy link
Member

Alkarex commented Apr 6, 2023

To get some of types right, some more types had to be added to related files.
I have made a number of fixes and improvements. Please double-check if possible

@ColonelMoutarde
Copy link
Contributor Author

To get some of types right, some more types had to be added to related files. I have made a number of fixes and improvements. Please double-check if possible

I think it's Ok

@Alkarex Alkarex merged commit d23d10b into FreshRSS:edge Apr 7, 2023
1 check passed
@ColonelMoutarde ColonelMoutarde deleted the feature/phpstan-view-file branch May 3, 2023 08:39
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request May 15, 2023
@Alkarex
Fix logs pagination
9614326 
Regression from FreshRSS#5269
@Alkarex Alkarex mentioned this pull request May 15, 2023
Merged
Alkarex
Alkarex reviewed May 15, 2023
View reviewed changes
app/views/index/logs.phtml
@@ -14,7 +14,7 @@
?>

<?php if (!empty($items)) { ?>
<?php $this->logsPaginator->render('logs_pagination.phtml', 'page'); ?>
<?php $this->logsPaginator->render('logs_pagination.phtml', 0); ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong, breaking the pagination. Fixed in #5403

Alkarex added a commit that referenced this pull request May 15, 2023
@Alkarex
Fix logs pagination (#5403)
c8d2ead 
* Fix logs pagination
Regression from #5269

* Add better default
math-GH pushed a commit to math-GH/FreshRSS that referenced this pull request Jul 4, 2023
@Alkarex @math-GH
Fix logs pagination (FreshRSS#5403)
80806ef 
* Fix logs pagination
Regression from FreshRSS#5269

* Add better default
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jan 18, 2024
@Alkarex
Native array return type forgotten
741a367 
Native type forgotten from
FreshRSS#5269
FreshRSS#5213
@Alkarex Alkarex mentioned this pull request Jan 18, 2024
Merged
Alkarex
Alkarex reviewed Jan 18, 2024
View reviewed changes
app/Models/CategoryDAO.php
* @param array<string,mixed> $listDAO
* @return array<int,FreshRSS_Category>
*/
private static function daoToCategoryPrepopulated(array $listDAO) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native array return type forgotten: fixed in #6046

Alkarex added a commit that referenced this pull request Jan 18, 2024
@Alkarex
Native array return type forgotten (#6046)
4a0e8a7 
Native type forgotten from
#5269
#5213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alkarex Alkarex Alkarex left review comments

Assignees
No one assigned
Labels
System care Everything related to the system care
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ColonelMoutarde @Alkarex