New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature important feeds #5782
Conversation
I hope @math-GH will be so kind to polish a bit the UI (e.g. icon and alignment) when we get that far :-P |
Interesting feature. IMHO I would not separate the "important feeds" from the "main stream". It would make sense to have the important feeds also in the main stream, wouldn't it? And I would keep this order:
What do you think? |
The feeds would still be in the "main stream" and categories underneath. |
I have updated several things and reworked the description in the first post of this thread |
It does look nice, and I kind of like it 🙂 |
An exclamation mark is also an obvious option. |
I thought about both options (exclamation mark and "top" icon) too. Why I did not chose one of them:
The pin icon came into my mind because of the feature that articles from important feeds will not be marked as read automatically in the main stream (if the config is not enabled) |
Let's go with your option for now @math-GH and we can maybe get some feedback before the next release |
Does it make sense to have the "Important feeds" menu item if there is no feed assigned to the "Important feed" channel? |
It is indeed cleaner to not show important feeds when there is no feed in that category. On the flip side, it makes this feature difficult to discover. (edit: same for my labels, which I consider always showing, also when there are no unread articles) I will look at the counting problems |
Fixed :-) |
Any comment? If nothing blocks, I will soon merge to get wider testing and feedback :-) |
Is it ok to collect feedback here? Or should I open a new issue or a discussion? |
As you prefer, @math-GH , I do not mind :-) |
First feedback after using it for some days: The mark as read function is not smart enough, because the user can mark the articles as read only in the "important feeds" channel. In the category channel and main stream, there should be an addtional button something like "mark important feed articles as read" |
Articles from important streams can be marked as read individually by opening them, or by clicking the envelope.
I am open to that; this was actually my first implementation, and I personally like it. I only changed to the current behaviour as an effort to simplify the understanding of the behaviour. More opinions welcome. I can make a PR.
I would rather avoid adding more buttons. This can be done from the "Important feeds" view or from the feeds view.
It was just an effort to help finding the relevant settings by repeating some of the same graphics. Changes welcome |
And within a single feed See FreshRSS#5782 (comment)
And within a single feed See #5782 (comment)
Take advantage of the feed priority information, to avoid missing updates from selected. important feeds (e.g. feeds with rare updates).
Option
New option for the feed visibility / priority:
UI
Important feeds can be styled differently (right now, double underline, but we might find something nicer later for each themes)
Also in aside feeds:
Also in feed management view:
Behaviour
Even when the mark as read on scroll option is turned on, articles from important feeds will not be marked as read automatically during scroll (but can still be marked as read manually).
(We might make an option to tweak this behaviour, but I would rather avoid introducing a new options if possible)