Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to mark articles as read on focus. #5812

Merged
merged 8 commits into from Nov 9, 2023

Conversation

passbe
Copy link
Contributor

@passbe passbe commented Nov 3, 2023

Closes #5723

Changes proposed in this pull request:

  • Allow a user to enable mark as read when focusing article.

How to test the feature manually:

  1. Enable "Mark an article as read... when focused" under Configuration > Reading > Mark article as read.
  2. Using shortcut "focus next without opening" confirm article is marked as read without opening.
  3. Using shortcut "focus previous without opening" confirm article is marked as read without opening.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Notes:

  • Other mark as read attributes are not documented. More than happy to write some if we believe the option isn't clear to the end user.
  • The automatic scrolling is a little jarring when using this feature. Out of scope of this PR but may consider further PR's to adjust in future.

@passbe passbe changed the title Added ability to mark entries as read on focus. Added ability to mark articles as read on focus. Nov 3, 2023
@Alkarex Alkarex added this to the 1.23.0 milestone Nov 3, 2023
@Alkarex Alkarex added the UX User experience label Nov 3, 2023
@Alkarex
Copy link
Member

Alkarex commented Nov 7, 2023

Thanks for the PR 👍🏻
I have fixed some minor things ( make fix-all ) and also used the batch mode for marking as read, so that when when using the shortcuts to quickly go through the list of articles, there aren't too many network requests made (save resources, and better performance). You are welcome to test

@Alkarex
Copy link
Member

Alkarex commented Nov 8, 2023

Added compatibility with #5782 and also with the already existing keep unread concept (if you manually mark an article as unread, it will not automatically be marked as read when moving over it - scroll or focus - as long as you are in the same view)

@passbe
Copy link
Contributor Author

passbe commented Nov 9, 2023

@Alkarex thank you for this. I've tested the feature and it works as expected. My only comment would be the lag in the interface between selecting the next item and it changing from read to unread in the UI. Something I may look to tweak in future. Appreciate your review.

@Alkarex
Copy link
Member

Alkarex commented Nov 9, 2023

My only comment would be the lag in the interface between selecting the next item and it changing from read to unread in the UI

Let's address that in another PR.
The current batch process timing is: wait 1s, repeat max every second.
It should be: wait 0s, repeat max every second.

@Alkarex Alkarex merged commit b9939bd into FreshRSS:edge Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark article as read after focus using hotkeys n/p
2 participants