-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core extensions: UserCSS, UserJS #6267
Conversation
The name is used for the directory where the configuration is stored and should not contain spaces. Since the name was changed, I reset the version number and changed to semantic versioning.
Changed the location of the configuration file to the user data directory, because it is not `static`. That way, the user's configurations are gathered in the user directory, which makes it easier to backup them.
Remove procedures to install the extension because it is no longer necessary.
Remove permission error indication because the storage location is now in the user data directory managed by the application.
Thanks! We will first issue FreshRSS 1.24 relatively soon and then address bigger changes such as this one in the edge version towards the next release |
I have done some refactoring. Please double-check. |
|
||
/** Return the user-specific, extension-specific, file content, or null if it does not exist */ | ||
protected final function getFile(string $filename): ?string { | ||
$content = @file_get_contents($this->getExtensionUserPath() . '/' . $filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we could try to see whether we could reduce the permissions for the extensions, so they can only call inherited functions
Version 0.0.1 will not be merged, so only version 1.0.0 will remain.
Thanks, nice refactoring. I think it is a good idea to make some functions |
All the extensions of https://github.com/FreshRSS/Extensions are tested automatically, at least |
I have made a new command to automatically test all known third-party FreshRSS extensions FreshRSS/Extensions#228 |
Closes FreshRSS/Extensions#227
Changes proposed in this pull request:
How to test the feature manually:
data/users/extensions/<extension-name>
.<head>
.Pull request checklist:
Additional information can be found in the documentation.