Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: overflow expanding title in entry header #6373

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 23, 2024

Before

Config article icons (default):
grafik

(A) mouse over an article expands the title with overlapping the date
grafik

If some icons are disabled
grafik

(B) The title expanding is buggy and in some cases the title does not expand - it shrinks
grafik

If the summary is enabled
grafik

(C) The title cannot be expanded by mouse over
grafik

After

(A) Similar as before
grafik

(B) The title does not shrinks while hovering
grafik

(C) The title expands
grafik

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 23, 2024
@math-GH math-GH added this to the 1.24.0 milestone Apr 23, 2024
@Alkarex Alkarex merged commit aac3b21 into FreshRSS:edge Apr 25, 2024
2 checks passed
@math-GH math-GH deleted the improve-overflow-entry_header branch April 25, 2024 07:14
@Alkarex
Copy link
Member

Alkarex commented Apr 26, 2024

Ups, regression: the date is always visible, also on small screen, making titles nearly impossible to read on mobile

@math-GH
Copy link
Contributor Author

math-GH commented Apr 26, 2024

Ups, regression: the date is always visible, also on small screen, making titles nearly impossible to read on mobile

I forgot to commit a little change :/

@Alkarex
Copy link
Member

Alkarex commented Apr 26, 2024

Another regression from here I think: the hover colour of the date in dark theme (Origine) is darker than non-hover, which is likely wrong:

image

@math-GH
Copy link
Contributor Author

math-GH commented Apr 27, 2024

That is not an regression, it is by purpose. The font color gets an opacity for a better title overlapping view.

Maybe we could improve the opacity

@Alkarex
Copy link
Member

Alkarex commented Apr 27, 2024

That is not an regression, it is by purpose. The font color gets an opacity for a better title overlapping view.

Ah right, but when there is no overlap, it looks strange. I believe it should have the same colour than the title

@Alwaysin
Copy link
Contributor

Alwaysin commented May 2, 2024

@math-GH This PR broke the suspension points in Dark theme by removing the dark filter on them.
Before:
chrome_z2Q0q2GFt6
After, whiter and brighter:
chrome_7K12cpxMi2

@math-GH
Copy link
Contributor Author

math-GH commented May 2, 2024

First I could confirm it. Font color is #888888 but the points are #cccccc

After trying something I cannot reproduce it. Strange.

@colinstu12
Copy link

Looking forward to this fix! Thanks! Ran into this issue myself and didn't think to report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants