Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: title hover: date opacity 0.3 -> 0.5 #6390

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 27, 2024

Improves #6373 (comment)

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 27, 2024
@math-GH math-GH added this to the 1.24.0 milestone Apr 27, 2024
@math-GH math-GH requested a review from Alkarex April 27, 2024 16:58
@Alkarex
Copy link
Member

Alkarex commented Apr 27, 2024

But now it fails in light mode :-P

image

The date should not become less visible when the article is highlighted, and it should probably have the same colour than the title

@math-GH
Copy link
Contributor Author

math-GH commented Apr 27, 2024

Thanks for your feedback. Would you suggest to revert the date behavior (do not change the font color while hovering)?

@Alkarex
Copy link
Member

Alkarex commented Apr 27, 2024

Would you suggest to revert the date behavior (do not change the font color while hovering)?

I have not looked at the implementation in details, but I think the date should have the same colour as the title, and if the title overlaps with the date, then use another mechanism to either hide the date completely or use a background for the title.

@math-GH
Copy link
Contributor Author

math-GH commented Apr 27, 2024

Would you suggest to revert the date behavior (do not change the font color while hovering)?

I(...) I think the date should have the same colour as the title,

that is not the current behaviour. I have not checked each theme in detail, but f.e. the Origine theme has a grey font color of the date.

and if the title overlaps with the date, then use another mechanism to either hide the date completely

it would hide the date also if the title does not overlap the date column.

or use a background for the title.

It is already implemented. But I cannot add too much padding between the last letter of the title and the border, because if could cut the last letters.

@Alkarex
Copy link
Member

Alkarex commented Apr 30, 2024

I think the date should have the same colour as the title,

that is not the current behaviour

Indeed, my bad, I was not remembering correctly.

Even with this PR, the date becomes less visible when hovering compared to when not hovering, which is what troubles me. It is a regression compared to version 1.23.1. It would be nice to fix if possible.

@math-GH
Copy link
Contributor Author

math-GH commented Apr 30, 2024

Back to the behavior of 1.23.1 while hovering.

This screenshot shows the issue while hovering and having the same font color of author and date:
grafik

@Alkarex
Copy link
Member

Alkarex commented Apr 30, 2024

Yes, there is a possible improvement there, but let's come back to it later. Maybe a CSS background opacity gradient or something else to mitigate the issue.

@Alkarex Alkarex merged commit d4ac7ea into FreshRSS:edge Apr 30, 2024
2 checks passed
@math-GH math-GH deleted the improve-date-while-hovering branch April 30, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants