Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker based setup #12

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Add docker based setup #12

merged 2 commits into from
Jul 6, 2023

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Jul 2, 2023

Closing #11

  • Server setup based on PHP 8.2
  • Env vars take precedence in env.php

@amenk
Copy link
Collaborator

amenk commented Jul 4, 2023

Thanks a lot, can you solve the conflicts?

R0Wi added 2 commits July 6, 2023 07:20
* Server setup based on PHP 8.2
* Env vars take precedence in env.php
* Add PHPUnit infrastructure
* Cover Env.template.php with tests
@R0Wi
Copy link
Contributor Author

R0Wi commented Jul 6, 2023

Thanks a lot, can you solve the conflicts?

Done @amenk . I needed to adjust quite a few lines in Env.template so I decided to add some tests in a separate commit (9ba7732). Please let me know if this is okay for you or if you'd rather like me to create a separate PR for this.

Tested the Docker setup and still seems to work 😄

@amenk amenk merged commit e4f514f into FriendlyCaptcha:main Jul 6, 2023
@amenk
Copy link
Collaborator

amenk commented Jul 6, 2023

Having so much code in the Env.template does not sound very elegant.

Thanks @R0Wi - now that we have composer in place we might as well use dotenv ...

But it's fine for now :-)

@R0Wi
Copy link
Contributor Author

R0Wi commented Jul 6, 2023

Using an external library like dotenv sounds definitely cleaner and it will reduce the code quite a bit. If you're interested I could create a PR for this aswell. We should just discuss how to bootstrap composer in that case. Would you like to leave it to the admin to install the dependencies via composer install or would you prefer to commit the vendor folder?

@amenk
Copy link
Collaborator

amenk commented Jul 6, 2023

Would leave that to the admin, vendor/ should not be commited ..

In the end of the day it would be nice to be able to use this also as a dependency in PHP projects but as well as standalone .. not sure how well this is possible :-)

@R0Wi
Copy link
Contributor Author

R0Wi commented Jul 6, 2023

Sounds good 👍

Think that should be possible somehow, let's see 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants