Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote doesn't embed URL/link picture #3

Open
Xaverri opened this issue Feb 8, 2018 · 4 comments
Open

Quote doesn't embed URL/link picture #3

Xaverri opened this issue Feb 8, 2018 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Xaverri
Copy link

Xaverri commented Feb 8, 2018

Hi! I'm sorry for contacting you this way; I couldn't find any other option and you are blocked from friend requests on Discord.

I've started using your bot recently and I found one feature that's listed in the release that doesn't seem to work: "If quoting a message with just a URL to an image, embed the image."

When quoting a message that was a link to a picture, the quote only shows the URL, and doesn't also embed the picture. I'm not sure if this is Discord limitations, but seeing as you listed it as one of the features, I was hoping if you could look into this. It would be great to have this working!

Keep up the great work.
xaverri#0496
image
image

@RalphORama RalphORama self-assigned this Feb 9, 2018
@RalphORama RalphORama added the bug Something isn't working label Feb 9, 2018
@RalphORama
Copy link
Member

Hi, just letting you know I received the bug report. I will investigate in the morning. Thanks!

@Xaverri
Copy link
Author

Xaverri commented Feb 16, 2018

Heya, just checking in. Any thoughts, yet? :)

@Xaverri Xaverri closed this as completed Feb 16, 2018
@Xaverri Xaverri reopened this Feb 16, 2018
@RalphORama
Copy link
Member

RalphORama commented Feb 19, 2018

Hey! Sorry about the delay. I'm balancing this, college, and a few other projects. I've got a proof-of-concept staged, but I have to test it with a few more image hosts before I push the commits to the main bot. You should see an update by the end of the week!

@RalphORama
Copy link
Member

Updated to support raw image URLs. Still need to add support for:

  • Tweets with pictures
  • Tumblr posts
  • Images with GET parameters (i.e. i.imgur.com/removed.png?value1=true&value2=abcde)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants