Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Better Embeds #1

Closed
bsquidwrd opened this issue Nov 16, 2017 · 2 comments
Closed

Better Embeds #1

bsquidwrd opened this issue Nov 16, 2017 · 2 comments
Assignees
@bsquidwrd
Labels
enhancement

Comments

@bsquidwrd
Copy link
Owner

Right now it embeds solo images but if there's text and an image(s) then it should quote all that as well
@bsquidwrd bsquidwrd self-assigned this Nov 16, 2017
@Al12rs
Copy link

Al12rs commented Jun 18, 2018 •
edited
Loading

You might be interested in this working implementation of quoting the entire message complete of images: https://github.com/RalphORama/QuoteBot/blob/master/cogs/quote.py
That bot is not really a quote bot as it requires the admin to first set a channel where all the quotes will be posted, basically a channel dedicated to pinning posts, which is not really what we want.
It does also copy over the the reactions from the original post but I don't think that is a good idea.

@Al12rs
Copy link

Al12rs commented Jun 19, 2018 •
edited
Loading

It seems that that solution is not complete either: FriendosClub/QuoteBot#3
It copies the link still so it's not the end of the world.

@bsquidwrd bsquidwrd changed the title Embed images Better Embeds Jul 23, 2018
bsquidwrd added a commit that referenced this issue Jul 23, 2018
@bsquidwrd
small fix for #1 in regards to needing text for field name
f5dbfd7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsquidwrd bsquidwrd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsquidwrd @Al12rs