Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 #4

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Support PHP 8.0 #4

merged 1 commit into from
Jan 21, 2021

Conversation

vincentchalamon
Copy link

No description provided.

@nicwortel nicwortel mentioned this pull request Nov 29, 2020
.travis.yml Outdated Show resolved Hide resolved
@phil-davis
Copy link

PHP 8.0 on Travis is working now.
Can someone merge this, and make a release so that people who have this as a dependency can also move forward to PHP 8.0?

@nicodmf
Copy link

nicodmf commented Jan 4, 2021

@dunglas do you have any reason not to merge this PR ?

@dunglas
Copy link

dunglas commented Jan 4, 2021

@nicodmf I'm not a maintainer of this project, I don't have the merge permission.

@phil-davis
Copy link

phil-davis commented Jan 4, 2021

@pamil I see that you merged a PR last year. Can you please review this one?
I guess that you have maintainer privs here?

Or @lchrusciel @Zales0123 ?

@Vasary
Copy link

Vasary commented Jan 20, 2021

Please merge this

@pamil pamil merged commit 85763f4 into FriendsOfBehat:master Jan 21, 2021
@pamil
Copy link
Member

pamil commented Jan 21, 2021

Thanks, Vincent! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants