Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in Symfony v3.4.5 #26

Closed
lsmith77 opened this issue Mar 4, 2018 · 6 comments
Closed

regression in Symfony v3.4.5 #26

lsmith77 opened this issue Mar 4, 2018 · 6 comments

Comments

@lsmith77
Copy link

lsmith77 commented Mar 4, 2018

causes:
FriendsOfSylius/SyliusImportExportPlugin#54

my band-aid fix was to set a conflict on ^3.4.5
FriendsOfSylius/SyliusImportExportPlugin#76

already reported the issue to the symfony core team:
symfony/symfony#26397

@lsmith77
Copy link
Author

lsmith77 commented Mar 6, 2018

@lsmith77
Copy link
Author

lsmith77 commented Mar 6, 2018

cc @kix @jakzal

@kix
Copy link

kix commented Mar 6, 2018

@lsmith77, my contribution to SymfonyMockerContainer was quite small, just a fix in an exception message; I'm not quite sure I can be very helpful here. Please correct me if I'm wrong.

@jakzal
Copy link

jakzal commented Mar 6, 2018

Not sure if it's related. MockerContainer doesn't override the constructor.

@lsmith77
Copy link
Author

FYI I have a fix here symfony/symfony#26427

BTW the issue is specifically introduced because the MockContainer does not have a constructor

@pamil
Copy link
Member

pamil commented Dec 19, 2018

Should be fixed now.

@pamil pamil closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants