Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] regression causing issues with container parameters with Behat #26397

Closed
lsmith77 opened this issue Mar 4, 2018 · 0 comments

Comments

@lsmith77
Copy link
Contributor

lsmith77 commented Mar 4, 2018

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.4.5

issue was introduced by c026ec6#diff-f7b23d463cba27ac5e4cb677f2be7623R985

results in:
https://travis-ci.org/FriendsOfSylius/SyliusImportExportPlugin/jobs/348897843#L923

see also:
FriendsOfSylius/SyliusImportExportPlugin#54

quick fix was to simply add a conflict on v3.4.5
FriendsOfSylius/SyliusImportExportPlugin#60

the issue is likely caused by extending the Container class:
https://github.com/PolishSymfonyCommunity/SymfonyMockerContainer/blob/master/src/PSS/SymfonyMockerContainer/DependencyInjection/MockerContainer.php#L7

symfony-splitter pushed a commit to symfony/dependency-injection that referenced this issue Mar 19, 2018
…ntainer class without a constructor (lsmith77)

This PR was merged into the 3.4 branch.

Discussion
----------

[DependencyInjection] fix regression when extending the Container class without a constructor

| Q             | A
| ------------- | ---
| Branch?       | 3.4+
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony#26397
| License       | MIT
| Doc PR        | -

fix regression introduced in symfony/symfony@c026ec6#diff-f7b23d463cba27ac5e4cb677f2be7623R985

Commits
-------

0beb64a fix regression when extending the Container class without a constructor
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
…ntainer class without a constructor (lsmith77)

This PR was merged into the 3.4 branch.

Discussion
----------

[DependencyInjection] fix regression when extending the Container class without a constructor

| Q             | A
| ------------- | ---
| Branch?       | 3.4+
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26397
| License       | MIT
| Doc PR        | -

fix regression introduced in c026ec6#diff-f7b23d463cba27ac5e4cb677f2be7623R985

Commits
-------

0beb64a fix regression when extending the Container class without a constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants