-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for Cake 3.0 #38
Conversation
You need to move the files in 1 commit, then make changes in another. |
Lesson learned for future, not going to spend time again on this one. |
Conflicts: src/Controller/Component/CsvViewComponent.php src/View/CsvView.php tests/TestCase/Controller/Component/CsvViewComponentTest.php tests/TestCase/View/CsvViewTest.php
Got back history https://github.com/FriendsOfCake/cakephp-csvview/blame/2.0/src/View/CsvView.php though not really useful due to the white space change. |
update readme for cake 3
@josegonzalez This is good to go imo. The component isn't essential for using the View class itself, so I suggest just drop it for now. It can be reintroduced later. |
Remove the component. I was never fond of it anyhow - I don't know why I even merged it in the first place... |
Done |
So the 3.c branch is in a usable state now? |
Yes, or at least should be :) |
You probably want |
Doh, I used
git mv
to move all files to new location yet it shows old ones as deleted :(The component needs to be updated to account for the fact that data array won't have model name keys anymore.Component was removed_serialize
=true
should be added as done for JsonView in Cake 3.1For now I am not raising my hand to take care of either :)