Upgrade for Cake 3.0 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to move the files in 1 commit, then make changes in another. |
|
Lesson learned for future, not going to spend time again on this one. |
Conflicts: src/Controller/Component/CsvViewComponent.php src/View/CsvView.php tests/TestCase/Controller/Component/CsvViewComponentTest.php tests/TestCase/View/CsvViewTest.php
|
Got back history https://github.com/FriendsOfCake/cakephp-csvview/blame/2.0/src/View/CsvView.php though not really useful due to the white space change. |
Closed
update readme for cake 3
|
@josegonzalez This is good to go imo. The component isn't essential for using the View class itself, so I suggest just drop it for now. It can be reintroduced later. |
|
Remove the component. I was never fond of it anyhow - I don't know why I even merged it in the first place... |
|
Done |
|
So the 3.c branch is in a usable state now? |
|
Yes, or at least should be :) |
|
You probably want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doh, I used
git mvto move all files to new location yet it shows old ones as deleted :(The component needs to be updated to account for the fact that data array won't have model name keys anymore.Component was removed_serialize=trueshould be added as done for JsonView in Cake 3.1For now I am not raising my hand to take care of either :)