Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incompatibility with FoF Gamification #54

Merged
merged 1 commit into from
Nov 6, 2021
Merged

fix: incompatibility with FoF Gamification #54

merged 1 commit into from
Nov 6, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Nov 6, 2021 •
edited
Loading

Changes proposed in this pull request:

Fixes incompatibility with Gamification (and possibly other extensions too).

Reviewers should focus on:

None

Screenshot

image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@davwheat davwheat self-assigned this Nov 6, 2021
imorland
imorland approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out fine locally 👍

@imorland imorland merged commit 0fd5d22 into master Nov 6, 2021
@imorland imorland deleted the dw/gamification-patch branch November 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees

@davwheat davwheat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davwheat @imorland