Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afford keyboard navigators the same styling rights as mouse users #259

Merged

Conversation

davwheat
Copy link
Member

This PR allows keyboard users to see what the upload button does (shows the upload text on focus).

Previously, the text was only shown on hover and, because there was no tooltip, there was no way to see the function of the button.

rUtsNT.mp4

Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to being a step closer to accessibility, thanks!

@imorland imorland merged commit 16528d9 into FriendsOfFlarum:master Jan 19, 2021
@davwheat davwheat deleted the add-missing-keyboard-styles branch January 19, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants