providing way to override default consul address #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Apr 18, 2017
Consul/Client.php
Outdated
| @@ -17,8 +17,15 @@ class Client | |||
|
|
|||
| public function __construct(array $options = array(), LoggerInterface $logger = null, GuzzleClient $client = null) | |||
| { | |||
| $base_uri = 'http://127.0.0.1:8500'; | |||
|
LGTM! The Consul docs and team encourage clients to support CONSUL_HTTP_ADDR. |
tucksaun
approved these changes
Apr 28, 2017
|
Thank you @benschw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONSUL_HTTP_ADDR(the var used by others clients to configure a consul address) is set, it is leveragedbase_uriis provided in options array, it is leveraged