Possibility to have multiple threads in one page

[ahilles107]

If you want have multiple threads on one page add the following code at a desired place in the template to load the comments

{% include 'FOSCommentBundle:Thread:async.html.twig' with {'thread_container': '.comments-box'} %}

Your page must have:

<div class="comments-box" data-thread-id="my_unique_thread_id_1"></div>
<div class="comments-box" data-thread-id="my_unique_thread_id_2"></div>

fixes #232

[stof]

typo here

[asm89]

Is this PR still a WIP? I can't imagine this code already works 100%. There are a lot of missing changes. Apart from that the current JS isn't designed for this (imo) and I'm not sure if I want to support this natively in the bundle with the current JS implementation.

[ahilles107]

@asm89 for me all is working god. About what missing changes you talking?

[ahilles107]

@asm89 - can you answer on my question?

[merk]

If we're going to end up doing something to natively support this, I would prefer to change FOS_COMMENT into an reusable class where you call something along the lines of this:

var thread = new FOS_COMMENT(thread_container, { url: url }); 

[mablae]

Hello,

I am facing the same problem: I want to include many threads on one page. (A bit like Facebook does with FriendStream).

So we should work on this feature, there is definitly a usecase. @asm89 could you please ping back what issues with this PR you are seeing (missing updates)?

cheers mablae

[merk]

I have plans to redo the javascript to support multiple threads, it will just take some time. I dont think this approach is the best one, I would prefer to move to a more object instance approach.

[mablae]

Sounds great!

[tarjei]

You may have to have a plan for how you register thread.permalink if you have multiple threads on the same page...

[merk]

A good point. My current code changes dont take into account using different permalinks. Will address this next time I work on it (and it is almost ready to merge into master!)

[RossOliver]

Hi, has there been any progress with this? I'm desperate for this functionality!

Many thanks.

[merk]

There has been progress but it has stalled for about a month now. I have what I consider to be the 3.0.0-alpha1 branch on my repository, but there is still more work to be done before pushing it. It contains large BC breaks and most users of FOSCommentBundle have probably not constrained their version to 2.0.*..

merk/FOSCommentBundle@master...new-javascript

[lerminou]

Hi, is it now fixed ? i really want to implement this functionnality.

[cordoval]

@lerminou he has it in this new-javascript branch meaning it has not been released yet, we are still in 2.0.x

👶

[tarjei]

@merk: Any news on the 3.0.0 branch?

[merk]

No sorry, I havent had time to dedicate to tidying it up. I still dont know when I will get a day to sort it out and release it.

The current state is at https://github.com/merk/FOSCommentBundle/tree/new-javascript

[qpleple]

any update on this?

[qpleple]

For those interested, I was able to have multiple threads on the same page using the original version of the bundle (without modifying any files):

• Include threads without AJAX (see documentation)

<div class="fos_comment_thread" data-thread="{{ thread.id }}">
    {% include 'FOSCommentBundle:Thread:comments.html.twig' with {
        'comments': comments,
        'thread': thread
    } %}
</div>

• before loading comments.js, change the thread container selector:

var fos_comment_thread_container = $('.fos_comment_thread');

It works because, in comments.js, event listeners are intialized by
thread_container.on(...) which works even if thread_container refers to multiple elements.

[tdaryani01]

any update on this?

[fundup]

Thanks @ahilles107 I did as you suggested. I spent time to understand and apply so the solution for those who are interested (I copy and include comment.js due to I don't use assetic):

https://gist.github.com/fundup/eb38be3a13d5581da3d1

[cjuhong]

@fundup
Is the variable fos_comment_thread_container used by any fucntions?

[fundup]

It seems to be DOM selector to insert comments so I think it's used

[cjuhong]

@fundup

I copy the code you shared, but I can't see any comment textarea box.

All the thread_containers are empty divs.

[cjuhong]

@ahilles107

I can't see any comment textarea box. All the thread_containers are empty divs.

[cjuhong]

@fundup @ahilles107

Hi,
following your instruction, the function getThreadComments() is never called to init the comment box UI.

[cjuhong]

Hi,

I found a hack solution for requirement:

adding a iframe tag and the src attribute point to a route which load the

jquery
and

{% include 'FOSCommentBundle:Thread:async.html.twig' with {'id': 'id'} %}

[flavienaudin]

Hi,
The issue is closed but it doesn't seem to be fixed. Is there any update about this feature ?
Thanks

[ksn135]

For those interested, I was able to have multiple threads on the same page using the original version
@qpleple thanks