votemanager issue

[helios-ag]

This commit is intended to discuss the following problem: how to restrict one vote per comment per user(voter)?
My solution (as for me) looks dirty, may be more experienced developers suggest a much better solution?
Also i have thoughts to make composite key (doctrine) combined from comment_id and voter_id, so a DBMS can restrict multiple votes per comment within same user.

[merk]

Theoretically, the bundle can already support this,

https://github.com/FriendsOfSymfony/FOSCommentBundle/blob/master/Creator/DefaultVoteCreator.php#L58

If you define validation constraints for your Vote model, the validation will fail and the vote will not be created.

[stof]

This is wrong. You flush conditionally, but this does not avoid the UnitOfWork being flushed by another part of the request.

The check should wrap the whole method if done this way.

Also, note that you don't follow the Symfony2 CS, and that the ODM version needs to behave the same way.

[Problematic]

@merk what kind of validation constraints would you recommend to achieve this?

[merk]

Potentially something like

<?php

use Symfony\Component\Validator\Constraints as Assert;
use Symfony\Bridge\Doctrine\Validator\Constraints as DoctrineAssert;
use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity
 * @DoctrineAssert\UniqueEntity({"comment", "user"})
 */
class Vote
{
// ...
}

Now, that isnt complete - the unique entity constraint should be on both the comment and user relationships but im not sure if it is supported or not.

Let me know if that works out for you. Unfortunately I'm on medical leave at the moment and I'm unable to spend much time debugging code.

[Problematic]

That was my first thought, too, but I've been playing around with it for a bit and can't get it to behave properly. I'll see what I can cook up.

[Problematic]

@helios-ag are you still working on this solution? If not, I may use it as inspiration if you don't mind. I opened #68 to use a model constraint because I thought it would be nice to have optional rate-limiting, but I've been thinking about it, and I can't think of a use-case where you wouldn't want to use rate limiting; it kind of defeats the point otherwise.

If you are still working on this, let us know how else we can help!

[merk]

I would like to see a solution to this but do not have a need for it.

The best idea I've come up with is a validator provided by FOSCB which will use the VoteManager to check if the user has voted within a specific time.

It would work something like the Unique validator provided by FOSUB (https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/Validator/UniqueValidator.php)

[stof]

@merk ping here

[merk]

I am closing this pull request because it isnt the right solution.

It should be possible to overwrite the VoteCreator to perform specific checks if the validator component is unable to cope with them.