Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #1938

Merged
merged 43 commits into from Mar 20, 2024
Merged

Support Symfony 7 #1938

merged 43 commits into from Mar 20, 2024

Conversation

evertharmeling
Copy link
Contributor

@evertharmeling evertharmeling commented Mar 20, 2024

Follow-up on #1933 to help move the SF 7 support forward.

  • Fixed the CI errors
  • Dropped support for Symfony 4.4, as it complicated the deprecation of MessageHandlerInterface (and the attribute being available in 5.4). Next to that Symfony 4.4 isn't supported anymore at this moment.

TODO

When doctrine/phpcr-odm releases 2.0 version

  • Remove "minimum-stability": "RC" from composer.json
  • Update version doctrine/phpcr-odm to ^1.5.3 || ^2.0 in composer.json
  • Update version jackalope/jackalope-doctrine-dbal to ^1.2 || ^2.0 in composer.json

PR could be merged in master, but the TODO's should be fixed in a new release of this bundle IMO.

l-you and others added 30 commits December 4, 2023 14:35
…e/phpcr-odm version should be used for php 8.3
… doctrine/phpcr-odm version should be used for php 8.3"

This reverts commit 22c8a4c.
…ny desired version without the need to update the rest of dependencies.
@llupa
Copy link
Contributor

llupa commented Mar 20, 2024

@XWB 👀

@XWB XWB merged commit 4164ca0 into FriendsOfSymfony:master Mar 20, 2024
20 checks passed
@XWB
Copy link
Member

XWB commented Mar 20, 2024

👍

@XWB
Copy link
Member

XWB commented Mar 20, 2024

Thank you for all the hard work.

@evertharmeling
Copy link
Contributor Author

Glad to be of help, thanks for the merge Karel!

@bastienho
Copy link

Thank you for this work.

When can we expect a release?

7ochem pushed a commit to 7ochem/FOSElasticaBundle that referenced this pull request Apr 18, 2024
* Update dependencies

* add php 8.3

* add symfony 7 to tests

* exclude php 7.4 from tests for symfony 7

* Exclude all php versions prior to 8.2 for Symfony 7. Minimum supported Symfony 7 php version is 8.2 https://symfony.com/releases/7.0

* Require minimum doctrine/phpcr-odm 1.5.3. This is the lowest version with support for php 8.*

* Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3

* Revert "Exclude php 8.3 symfony 7 lowest dependencies from CI. Higher doctrine/phpcr-odm version should be used for php 8.3"

This reverts commit 22c8a4c.

* Run cs fixer

* fix code style

* fix a suddenly excluded case

* Lock to symfony/console@^6.1 because of issue with doctrine/phpcr-odm as described in FriendsOfSymfony#1933 (comment)

* run cs fixer

* Bump jms/serializer-bundle to v5

* Remove jms/serializer-bundle v3 support because php 7.2 has reached an end of life https://www.php.net/supported-versions.php

* add php 8.3 to phpstan

* Update all Symfony references to ^6.3

* Add symfony/console 7.0 to dependencies.

* Normalize continuous integration matrix.

* Normalize continuous integration matrix.

* update gitignore

* fix gitignore

* fix typo

* Replace php-cs-fixer with a shim version. It allows us to lock with any desired version without the need to update the rest of dependencies.

* Run php-cs-fixer with locked version 3.8.0.

* Add support for doctrine/phpcr-odm 2-beta release.

* Cs fixer fix

* Bump knplabs/knp-components

* Fix php cs fixer version.

* CS Fixer fixes with version 3.8.0.

* Add symfony/stopwatch because it's required by project

* Bumb jackalope/jackalope-doctrine-dbal to RC-1

* Normalize composer

* Disable symfony testing with php 8.2 and 8.3

* minimum stability RC

* [cs] Fix composer.json

* [phpunit] Fix 'framework.annotations' error

* [phpunit] Fix 'getAliasNamespace' error

* [phpunit] Not use CodeExtension anymore

* [phpunit] Variable 'profile_type' does not exist

* Make use of 'AsMessageHandler' attribute in favor of MessageHandlerInterface + dropped support for SF 4.4 (as AsMessageHandler is available in SF 5.4)

* [phpstan] Excluded AsyncPersistPageHandler as attributes are not supported

* [phpstan] Fix ContainerAwareInterface not found

---------

Co-authored-by: Liakhovskyi Vladyslav <vlad@revotale.com>
Co-authored-by: Liakhovskyi Vladyslav <rusted@revotale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants